Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
e7ded5dd
Commit
e7ded5dd
authored
Jan 03, 2024
by
Rémi Bernon
Committed by
Alexandre Julliard
Jan 04, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
dmime: Avoid leaking track references in segment Clone and Load.
Wine-Bug:
https://bugs.winehq.org/show_bug.cgi?id=56117
parent
a0669a27
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
1 deletion
+4
-1
segment.c
dlls/dmime/segment.c
+4
-1
No files found.
dlls/dmime/segment.c
View file @
e7ded5dd
...
@@ -442,7 +442,9 @@ static HRESULT WINAPI segment_Clone(IDirectMusicSegment8 *iface, MUSIC_TIME star
...
@@ -442,7 +442,9 @@ static HRESULT WINAPI segment_Clone(IDirectMusicSegment8 *iface, MUSIC_TIME star
LIST_FOR_EACH_ENTRY
(
entry
,
&
This
->
tracks
,
struct
track_entry
,
entry
)
LIST_FOR_EACH_ENTRY
(
entry
,
&
This
->
tracks
,
struct
track_entry
,
entry
)
{
{
if
(
FAILED
(
hr
=
IDirectMusicTrack_Clone
(
entry
->
pTrack
,
start
,
end
,
&
track
)))
break
;
if
(
FAILED
(
hr
=
IDirectMusicTrack_Clone
(
entry
->
pTrack
,
start
,
end
,
&
track
)))
break
;
if
(
FAILED
(
hr
=
segment_append_track
(
clone
,
track
,
entry
->
dwGroupBits
,
entry
->
flags
)))
break
;
hr
=
segment_append_track
(
clone
,
track
,
entry
->
dwGroupBits
,
entry
->
flags
);
IDirectMusicTrack_Release
(
track
);
if
(
FAILED
(
hr
))
break
;
}
}
*
segment
=
(
IDirectMusicSegment
*
)
&
clone
->
IDirectMusicSegment8_iface
;
*
segment
=
(
IDirectMusicSegment
*
)
&
clone
->
IDirectMusicSegment8_iface
;
...
@@ -822,6 +824,7 @@ static HRESULT WINAPI segment_persist_stream_Load(IPersistStream *iface, IStream
...
@@ -822,6 +824,7 @@ static HRESULT WINAPI segment_persist_stream_Load(IPersistStream *iface, IStream
This
->
header
.
mtLength
=
1
;
This
->
header
.
mtLength
=
1
;
if
(
FAILED
(
hr
=
wave_track_create_from_chunk
(
stream
,
&
chunk
,
&
track
)))
break
;
if
(
FAILED
(
hr
=
wave_track_create_from_chunk
(
stream
,
&
chunk
,
&
track
)))
break
;
hr
=
segment_append_track
(
This
,
(
IDirectMusicTrack
*
)
track
,
1
,
0
);
hr
=
segment_append_track
(
This
,
(
IDirectMusicTrack
*
)
track
,
1
,
0
);
IDirectMusicTrack8_Release
(
track
);
break
;
break
;
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment