Commits · 06e0220ed6f4b842cf5903fc17d12bdad8e8f379 · wine / wine-winehq

21 Dec, 2021 3 commits

mshtml: Avoid null pointer dereference in OmHistory_get_length (cppcheck). · 06e0220e

authored Dec 19, 2021

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

06e0220e

wldap32: Fix memory leak on error path in create_page_control (cppcheck). · 3f245899

authored Dec 20, 2021

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

3f245899

nsiproxy: Fix use after free in icmp_send_echo (scan-build). · 06923f61

authored Dec 20, 2021

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

06923f61

20 Dec, 2021 14 commits

mountmgr: Change scope of variable pvd in VOLUME_GetSuperblockLabel (cppcheck). · 656d7f58

authored Dec 19, 2021

The data in pvd was being accessed through the label_ptr variable after
pvd went out of scope.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

656d7f58

quartz: Fix memory leaks on error paths in FilterMapper3_RegisterFilter (cppcheck). · 8e081d32

authored Dec 19, 2021

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

8e081d32

dinput: Ignore objects without a collection in init_pid_caps. · 531297a8

authored Dec 20, 2021

This makes sure we don't try to set effect_state report id from objects
without a collection, causing some false warnings.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

531297a8

dinput: Convert wide action format back to ansi in ConfigureDevices. · e5131028

authored Dec 20, 2021

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52198Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

e5131028

dinput: Ignore NULL callback in IDirectInput_ConfigureDevices. · a37346c6

authored Dec 20, 2021

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52198Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

a37346c6

dinput: Keep action names when converting back to ansi. · dd1f3434

authored Dec 20, 2021

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52198Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

dd1f3434

winetest: Send the tests output to stdout when given "-o -". · 2da7e5de

authored Dec 20, 2021

This makes it easier to use WineTest with tools that capture stdout,
such as the TestBot.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

2da7e5de

cmd: Don't crash on 'if exist' without parameter. · 535da775

authored Dec 20, 2021

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51598Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

535da775

kernelbase: Don't hardcode magic constants. · 488a00c3

authored Dec 18, 2021

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

488a00c3

winedbg: Fix disassemble with end addresses exceeding 32-bit. · f174f18f
Bernhard Übelacker authored Dec 18, 2021
```
Signed-off-by: Bernhard Übelacker <bernhardu@mailbox.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
f174f18f

win32u: Fix memory leak on error path in PATH_WidenPath (cppcheck). · d45d54ef

authored Dec 20, 2021

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

d45d54ef

nsiproxy: Fix memory leaks on error paths in get_ipv6_addr_scope_table (cppcheck). · cf7dd520

authored Dec 19, 2021

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

cf7dd520

dinput8/tests: Don't test value again if it wasn't touched. · 3ee28693

authored Dec 18, 2021

Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

3ee28693

win32u: Use null driver to handle virtual display devices. · e63f7b7a

authored Dec 17, 2021

All drivers support UpdateDisplayDevices now, so we can avoid a server
call by being explicit in the null driver.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52180Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

e63f7b7a

17 Dec, 2021 15 commits

Release 7.0-rc2. · 2f5f8b4b
Alexandre Julliard authored Dec 17, 2021
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
2f5f8b4b

ntdll: Don't set socket IO status after queuing async. · 652dc005

authored Dec 16, 2021

Signed-off-by: Paul Gofman <pgofman@codeweavers.com>
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

652dc005

wined3d: Add WINED3DFMT_R11G11B10_FLOAT vertex format. · b006a4c5

authored Dec 17, 2021

Used by Dark Souls: Remastered.
Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

b006a4c5

server/console: Ensure conhost has created the TTY input stream before waiting. · 751a3325

authored Dec 17, 2021

Some PE executables (like mingw's gdb port) just do something like:
- WaitForSingleObject(GetStdHandle(STD_INPUT_HANDLE), INFINITE) and hang
  for ever (the read operations are done *after* the wait operation
  succeeds)
(of course, the real wait operation is more complex, but the problematic
part boils down to that)

This hangs for ever because conhost's main input thread hasn't been started
yet.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

751a3325

wined3d: Release the allocator lock on error in wined3d_allocator_chunk_vk_map(). · 44cb2ba9
Henri Verbeet authored Dec 17, 2021
```
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
44cb2ba9

inetmib1: Fix endianess issue with dwLocalAddr and dwLocalPort. · 9145b551

authored Dec 16, 2021

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52224Signed-off-by: Bernhard Übelacker <bernhardu@mailbox.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

9145b551

winedump: Support dumping quad word values in enumerations. · a9c17746
Eric Pouech authored Dec 15, 2021
```
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
a9c17746

ntdll: Don't use inline assembly in do_cpuid. · d0413d83

authored Dec 17, 2021

Avoids problems on old GCC.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51862Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

d0413d83

ntdll: Use proper names for magic constants. · 594036d6

authored Dec 17, 2021

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

594036d6

winepulse.drv: Write data to pulse in pulse_release_render_buffer. · 033cd601

authored Dec 16, 2021

Instead of waiting for the timer loop, which sometimes causes pulse
buffer underflows.

This greatly reduces the amount of underflows in Prince of Persia: The
Forgotten Sands, as well as in Forza Horizon 4 introduction and menu
audio, which are suffering from audio clicks since PE xaudio conversion.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52225Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

033cd601

winepulse.drv: Keep buffer size separate from allocated size. · 262c5211

authored Dec 16, 2021

So that it rounds to integral audio frame count.

262c5211

winepulse.drv: Stop writing the same data again on underflow. · 6995b77a

authored Dec 16, 2021

Data in [lcl_offs_bytes;lcl_offs_bytes+held_bytes] is the data we've
received from the client and that we consider being used by pulse,
regardless of how we write it to it.

A subset of this is [pa_offs_bytes;pa_offs_bytes+pa_held_bytes], which
is the data we have received from the client but not yet written to
pulse.

If pulsed has underflown it means that it has used all the data we've
written already, and resetting pa_offs_bytes and pa_held_bytes like here
will only make us write the same data again (in addition to silence) to
mend the underflow, ending up with potentially duplicate audio frames
being played.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52225Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

6995b77a

d3d11/tests: Mark a couple of failing tests as todo. · 91fb87b2
Alexandre Julliard authored Dec 17, 2021
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
91fb87b2
wininet/tests: Mark a failing test as todo. · 13966ac9
Alexandre Julliard authored Dec 17, 2021
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
13966ac9
crypt32/tests: Mark a failing test as todo. · b714ed41
Alexandre Julliard authored Dec 17, 2021
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
b714ed41

16 Dec, 2021 8 commits

user32: Free the created icon handle when using LR_COPYFROMRESOURCE. · 97bf2e7e

authored Dec 16, 2021

Spotted by John Sullivan.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52207Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

97bf2e7e

user32: Call DestroyIcon() to delete icon handles in CopyImage(). · 4a200821

authored Dec 16, 2021

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52207Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

4a200821

msvcrt: Fix double-free and memory leak in type_info destructor. · 01111b94

authored Dec 16, 2021

Spotted by toying with the gcc's static analyzer.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

01111b94

dbghelp: Silence some FIXMEs. · 6c64e6de

authored Dec 15, 2021

Reading gecko's PDB generate a lot of those.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

6c64e6de

winebuild: Allow using clang for as command. · f4ddcc36

authored Dec 16, 2021

Since a9b5bb32, Wine needs
get_as_command to work without cc_command available. While as is usually
a GCC dependency, Clang toolchains may not contain it.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

f4ddcc36

advapi32/tests: Skip event log tests on Windows when access is not allowed. · ea7eb956
Alexandre Julliard authored Dec 16, 2021
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
ea7eb956
schedsvc/tests: Fix a test failure on recent Windows versions. · 2c1a68e3
Alexandre Julliard authored Dec 16, 2021
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
2c1a68e3
kernelbase/tests: Fix some test failures on Windows. · f08eb97c
Alexandre Julliard authored Dec 16, 2021
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
f08eb97c