Commits · 7d550de26391cfe4234568ddffab6a942319dc6b · wine / wine-winehq

16 Aug, 2018 40 commits

sane.ds: Avoid an ARRAY_SIZE-like macro. · 7d550de2

authored Aug 16, 2018

Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

7d550de2

gdiplus/tests: Fix region leak (Coverity). · a9bc0fec

authored Aug 12, 2018

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

a9bc0fec

msi/tests: Add a test for asynchronous custom actions. · 6387476d

authored Aug 16, 2018

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

6387476d

msiexec: Don't keep the custom action GUID in the main thread's stack. · 25926905

authored Aug 16, 2018

Since it could potentially change on us during an asynchronous custom action.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

25926905

msi: Don't refcount the msi_custom_action_info struct. · b7f06acc

authored Aug 16, 2018

This is unnecessary, and may have always been so. The struct will either be
freed after it completes synchronously, or after it has completed
asynchronously in ACTION_FinishCustomActions().
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

b7f06acc

msi: Protect communication with the custom action server with a critical section. · 583edf7f

authored Aug 16, 2018

Avoids a potential race whereby an asynchronous custom action receives the
wrong thread handle.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

583edf7f

msi: Don't start the custom action server inside of custom_client_thread(). · 3a884c2e

authored Aug 16, 2018

Asynchronous custom actions don't wait for custom_client_thread() to
terminate, so it's possible for two consecutive actions to both try to start
the server at once, causing failures when the second action e.g. receives
ERROR_PIPE_BUSY from CreateNamedPipe().
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

3a884c2e

winecfg: Allow to disable MIME-type associations. · 186ae9ed

authored Jul 25, 2018

Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

186ae9ed

server: Remove no longer needed client and server pointers. · 6098af82
Jacek Caban authored Aug 16, 2018
```
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
6098af82
server: Remove no longer needed pipe reference from pipe server object. · 0ae95951
Jacek Caban authored Aug 16, 2018
```
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
0ae95951
server: Use pipe stored in pipe_end in set_named_pipe_info. · 6498ea18
Jacek Caban authored Aug 16, 2018
```
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
6498ea18
server: Use pipe stored in pipe_end in get_named_pipe_info. · 3375ccba
Jacek Caban authored Aug 16, 2018
```
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
3375ccba
server: Use common implementation for client and server get_file_info. · 6f6f6e59
Jacek Caban authored Aug 16, 2018
```
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
6f6f6e59
server: Use common implementation for pipe client and server get_sd and set_sd. · c0905e08
Jacek Caban authored Aug 16, 2018
```
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
c0905e08

server: Store named_pipe reference in pipe_end struct. · ba40a0db

authored Aug 16, 2018

Allows pipe clients to access named_pipe object after server is closed
without disconnecting.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

ba40a0db

ntdll/tests: Add more NtQueryInformationFile tests. · 59dd8bae

authored Aug 16, 2018

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

59dd8bae

kernel32/tests: Add more pipe tests. · a9ef1dd5

authored Aug 16, 2018

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

a9ef1dd5

dwrite: Multiply run analysis transform by dpi scale factor. · 7e0d1025
Nikolay Sivov authored Aug 16, 2018
```
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
7e0d1025

d2d1: Fix scaling when rendering text in bitmap mode. · 32b35f80

authored Aug 16, 2018

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

32b35f80

kernel32: Add AttachConsole implementation. · 57212f64

authored Aug 09, 2018

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41573
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=43910Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

57212f64

cmd: Handle quotes when parsing the folders in the PATH environment variable. · d175419f

authored Aug 02, 2018

Semicolons are also allowed inside a path, as long as they are quoted.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45552Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

d175419f

libwine: Use getsegmentdata(3) on Mac OS to find the end of the __TEXT segment. · bdca749f

authored Aug 01, 2018

Don't assume it ends with the fake PE header. This assumption doesn't
hold on Mac OS: the __data section where it was placed is located after
several other sections, all in the __DATA segment.

Unfortunately, this causes Wine, when DEP/NX is turned off, to override
the page protections for the start of the __DATA segment, removing write
permission from them, leading to a crash when winemac.drv attempted to
use an Objective-C class for the first time.

Also, be sure to include the zero-fill (i.e. BSS) sections in the total
size of the .data section. This should fix some tests that use large
uninitialized arrays.
Signed-off-by: Chip Davis <cdavis@codeweavers.com>
Signed-off-by: Ken Thomases <ken@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

bdca749f

setupapi: Correctly implement SetupDiDeleteDeviceInterfaceRegKey(). · 9b767ad6
Zebediah Figura authored Jul 29, 2018
```
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
9b767ad6

setupapi: Correctly implement SetupDiCreateDeviceInterfaceRegKey(). · 1d17352c

authored Jul 29, 2018

This family of functions manipulates the "Device Parameters" subkey, not its
parent.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

1d17352c

setupapi: Merge the InterfaceInfo and InterfaceInstances structs. · 86d26dde

authored Jul 29, 2018

It seems the original motivation for separating these was to facilitate easy
enumeration of specific classes using SetupDiEnumDeviceInterfaces(), but it
makes other things unnecessarily complex [including an eventual
implementation of SetupDiRemoveDeviceInterface()] and the implementation
provided here seems quite simple enough.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

86d26dde

setupapi: Add helper functions to get the path of the device instance keys. · ad9e1883
Zebediah Figura authored Jul 29, 2018
```
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
ad9e1883

setupapi: Don't use SP_DEVINFO_DATA in internal structs. · 11d09c29

authored Jul 29, 2018

And especially don't use a pointer to one, since there's no guarantee it'll
remain stable.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

11d09c29

setupapi: Merge the DeviceInstance and DeviceInfo structs. · 5d7b123d

authored Jul 29, 2018

These are two different representations of the same underlying object;
there's no reason to keep them separate.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

5d7b123d

setupapi: Add an internal helper for SetupDiSetDeviceRegistryProperty(). · b5b09649

authored Jul 29, 2018

This essentially follows the model used in MSI. The next patch makes use of
this helper.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

b5b09649

setupapi: Use a handle table to allocate device nodes. · f840bcc6

authored Jul 29, 2018

The size of DEVINST is DWORD, so using the pointer directly won't work on
64-bit.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

f840bcc6

setupapi: Remove a pointless cast. · a3cedc1f

authored Jul 29, 2018

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

a3cedc1f

dxgi: Prefer vkGet*ProcAddr() for loading Vulkan functions. · df84cb38

authored Aug 15, 2018

Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

df84cb38

d3d12: Return DXGI_ERROR_SDK_COMPONENT_MISSING from D3D12GetDebugInterface(). · 8f13509d

authored Aug 15, 2018

Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

8f13509d

dxgi: Return DXGI_ERROR_SDK_COMPONENT_MISSING from DXGIGetDebugInterface1(). · a608ef1f

authored Aug 15, 2018

Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

a608ef1f

d3d11/tests: Add a test for CopySubresourceRegion() with 3D textures. · a5aee1e1

authored Aug 16, 2018

Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

a5aee1e1

wined3d: Allow copying between different texture types. · 2aa5b001

authored Aug 15, 2018

Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

2aa5b001

wined3d: Mark vOutputControlPointID register as scalar. · 64be1974

authored Aug 15, 2018

Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

64be1974

wined3d: Use snprintf() in shader_arb_request_a0() (Coverity). · becec522

authored Aug 15, 2018

Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

becec522

wined3d: Use snprintf() in init_debug_buffer() (Coverity). · f51f911a

authored Aug 15, 2018

Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

f51f911a

wined3d: Add fall through comment in texture2d_blt_fbo() (Coverity). · bdc0a990

authored Aug 15, 2018

Signed-off-by: Józef Kucia <jkucia@codeweavers.com>
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

bdc0a990