no functional change

Backport from this commit:

  commit 8dfd98245d2c44a1eb4c8b7c275e6cfc10fe40f1
  Author: Chase Douglas <chase.douglas@canonical.com>
  Date:   Wed Apr 11 11:14:51 2012 -0700

    Fix copy/paste error from before git history in UpdateCurrentTimeIf()

    See UpdateCurrentTime() for reference. I don't know what bug this might
    trigger, but it wouldn't hurt to fix this.
Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>

Looks like a copy'n'paste error.

to make them all fit in the same naming scheme that better describes their purpose.

drop the nxagent prefix to emphasize they are not called from the
outside. Also make them static and add prototypes, if missing.

For now deactivate nxagentResetSelectionOwner. Must do some research
before removing it completely.

There were two location where the windowPtr was not cleared after
calling ClearSelectionOwner(). One was nxagentInitClipboard where it
was set to NULL before and the second one was nxagentClearSelection()
where it really should be reset.

So we can safely move this to where it really belongs.

and correctly print its value in debugging output

ensure same order for internal and external Atoms

Fixes ArcticaProject/nx-libs#907 (3/3)

Fixes ArcticaProject/nx-libs#907 (2/3)

nxagentCorrupted* were defined twice!

Fixes ArcticaProject/nx-libs#907 (1/3)

plus some whitespace improvements

Static analyzer reported: (error) Uninitialized variable: elements

Attributes ArcticaProject/nx-libs#905

Improve visibility by unindenting. Also move the ifdefs _before_ the
according comments. Finally merge ifdefs to fewer blocks.

Fix warning with NX_DEBUG_INPUT:

NXproperty.c: In function ‘ProcChangeProperty’:
NXproperty.c:210:7: warning: implicit declaration of function ‘nxagentGuessDumpInputInfo’; did you mean ‘nxagentGuessClientHint’? [-Wimplicit-function-declaration]
       nxagentGuessDumpInputInfo(client, stuff->property, (char *) &stuff[1]);
       ^~~~~~~~~~~~~~~~~~~~~~~~~
       nxagentGuessClientHint

Display.c: In function ‘nxagentResetDisplayHandlers’:
Display.c:901:5: warning: implicit declaration of function ‘nxagentReleaseAllSplits’; did you mean ‘nxagentWakeupBySplit’? [-Wimplicit-function-declaration]
     nxagentReleaseAllSplits();
     ^~~~~~~~~~~~~~~~~~~~~~~
     nxagentWakeupBySplit

As reported by static analyzer:
(error) Common realloc mistake: 'nxagentVisuals' nulled but not freed upon failure

As reported by static analyzer:
(error) Common realloc mistake: 'ptr' nulled but not freed upon failure

Attributes ArcticaProject/nx-libs#905

Fix these warnings with NX_DEBUG_INPUT enabled:

NXdispatch.c: In function ‘Dispatch’:
NXdispatch.c:350:74: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ {aka ‘unsigned int’} [-Wformat=]
           fprintf(stderr, "Session: Session started at '%s' timestamp [%lu].\n",
                                                                        ~~^
                                                                        %u
                       GetTimeAsString(), GetTimeInMillis());

Reconnect.c: In function ‘nxagentHandleConnectionStates’:
Reconnect.c:303:74: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ {aka ‘unsigned int’} [-Wformat=]
         fprintf(stderr, "Session: Session suspended at '%s' timestamp [%lu].\n", GetTimeAsString(), GetTimeInMillis());
                                                                        ~~^                          ~~~~~~~~~~~~~~~~~
                                                                        %u
Reconnect.c: In function ‘nxagentReconnectSession’:
Reconnect.c:673:66: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ {aka ‘unsigned int’} [-Wformat=]
   fprintf(stderr, "Session: Session resumed at '%s' timestamp [%lu].\n", GetTimeAsString(), GetTimeInMillis());
                                                                ~~^                          ~~~~~~~~~~~~~~~~~
                                                                %u

As reported by static analyzer.

Attributes ArcticaProject/nx-libs#905