process_bug.cgi 52.9 KB
Newer Older
1
#!/usr/bonsaitools/bin/perl -wT
2
# -*- Mode: perl; indent-tabs-mode: nil -*-
terry%netscape.com's avatar
terry%netscape.com committed
3
#
4 5 6 7 8 9 10 11 12 13
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
terry%netscape.com's avatar
terry%netscape.com committed
14
# The Original Code is the Bugzilla Bug Tracking System.
15
#
terry%netscape.com's avatar
terry%netscape.com committed
16
# The Initial Developer of the Original Code is Netscape Communications
17 18 19 20
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
terry%netscape.com's avatar
terry%netscape.com committed
21
# Contributor(s): Terry Weissman <terry@mozilla.org>
22
#                 Dan Mosedale <dmose@mozilla.org>
23
#                 Dave Miller <justdave@syndicomm.com>
24
#                 Christopher Aillon <christopher@aillon.com>
25
#                 Myk Melez <myk@mozilla.org>
terry%netscape.com's avatar
terry%netscape.com committed
26

27 28 29
use diagnostics;
use strict;

30 31 32
my $UserInEditGroupSet = -1;
my $UserInCanConfirmGroupSet = -1;

33 34
use lib qw(.);

35
require "CGI.pl";
36 37
require "bug_form.pl";

38
use RelationSet;
39 40 41

# Shut up misguided -w warnings about "used only once":

42 43 44 45 46 47 48 49 50 51 52 53 54
use vars qw(%versions
          %components
          %COOKIE
          %MFORM
          %legal_keywords
          %legal_opsys
          %legal_platform
          %legal_priority
          %settable_resolution
          %target_milestone
          %legal_severity
          %superusergroupset
          $next_bug);
55

56
ConnectToDatabase();
57
my $whoid = confirm_login();
58

59 60
my $requiremilestone = 0;

61 62
use vars qw($template $vars);

63 64 65 66 67 68 69 70
######################################################################
# Begin Data/Security Validation
######################################################################

# Create a list of IDs of all bugs being modified in this request.
# This list will either consist of a single bug number from the "id"
# form/URL field or a series of numbers from multiple form/URL fields
# named "id_x" where "x" is the bug number.
71 72
# For each bug being modified, make sure its ID is a valid bug number 
# representing an existing bug that the user is authorized to access.
73 74
my @idlist;
if (defined $::FORM{'id'}) {
75
    ValidateBugID($::FORM{'id'});
76
    push @idlist, $::FORM{'id'};
77
} else {
78 79
    foreach my $i (keys %::FORM) {
        if ($i =~ /^id_([1-9][0-9]*)/) {
80 81 82
            my $id = $1;
            ValidateBugID($id);
            push @idlist, $id;
83
        }
84 85 86
    }
}

87 88 89 90 91
# Make sure there are bugs to process.
scalar(@idlist)
  || DisplayError("You did not select any bugs to modify.")
  && exit;

92 93 94 95 96 97 98 99 100 101
# If we are duping bugs, let's also make sure that we can change 
# the original.  This takes care of issue A on bug 96085.
if (defined $::FORM{'dup_id'} && $::FORM{'knob'} eq "duplicate") {
    ValidateBugID($::FORM{'dup_id'});

    # Also, let's see if the reporter has authorization to see the bug
    # to which we are duping.  If not we need to prompt.
    DuplicateUserConfirm();
}

102 103
ValidateComment($::FORM{'comment'});

104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121
# If the bug(s) being modified have dependencies, validate them
# and rebuild the list with the validated values.  This is important
# because there are situations where validation changes the value
# instead of throwing an error, f.e. when one or more of the values
# is a bug alias that gets converted to its corresponding bug ID
# during validation.
foreach my $field ("dependson", "blocked") {
    if (defined($::FORM{$field}) && $::FORM{$field} ne "") {
        my @validvalues;
        foreach my $id (split(/[\s,]+/, $::FORM{$field})) {
            next unless $id;
            ValidateBugID($id, 1);
            push(@validvalues, $id);
        }
        $::FORM{$field} = join(",", @validvalues);
    }
}

122 123 124 125
######################################################################
# End Data/Security Validation
######################################################################

126 127
print "Content-type: text/html\n\n";

128 129
# Start displaying the response page.
$vars->{'title'} = "Bug processed";
130
$template->process("global/header.html.tmpl", $vars)
131 132 133
  || ThrowTemplateError($template->error());

$vars->{'header_done'} = 1;
134

135 136
GetVersionTable();

137 138 139
CheckFormFieldDefined(\%::FORM, 'product');
CheckFormFieldDefined(\%::FORM, 'version');
CheckFormFieldDefined(\%::FORM, 'component');
140

141 142 143
# check if target milestone is defined - matthew@zeroknowledge.com
if ( Param("usetargetmilestone") ) {
  CheckFormFieldDefined(\%::FORM, 'target_milestone');
144 145
}

146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162
#
# This function checks if there is a comment required for a specific
# function and tests, if the comment was given.
# If comments are required for functions  is defined by params.
#
sub CheckonComment( $ ) {
    my ($function) = (@_);
    
    # Param is 1 if comment should be added !
    my $ret = Param( "commenton" . $function );

    # Allow without comment in case of undefined Params.
    $ret = 0 unless ( defined( $ret ));

    if( $ret ) {
        if (!defined $::FORM{'comment'} || $::FORM{'comment'} =~ /^\s*$/) {
            # No comment - sorry, action not allowed !
163 164
            ThrowUserError("You have to specify a <b>comment</b> on this change.  
                            Please give some words on the reason for your change.");
165 166 167 168 169 170 171
        } else {
            $ret = 0;
        }
    }
    return( ! $ret ); # Return val has to be inverted
}

172 173 174 175 176 177 178 179 180
# Figure out whether or not the user is trying to change the product
# (either the "product" variable is not set to "don't change" or the
# user is changing a single bug and has changed the bug's product),
# and make the user verify the version, component, target milestone,
# and bug groups if so.
if ( $::FORM{'id'} ) {
    SendSQL("SELECT product FROM bugs WHERE bug_id = $::FORM{'id'}");
    $::oldproduct = FetchSQLData();
}
181 182 183 184
if ((($::FORM{'id'} && $::FORM{'product'} ne $::oldproduct) 
     || (!$::FORM{'id'} && $::FORM{'product'} ne $::dontchange))
    && CheckonComment( "reassignbycomponent" ))
{
185
    CheckFormField(\%::FORM, 'product', \@::legal_product);
186
    my $prod = $::FORM{'product'};
187 188 189 190 191 192 193 194 195

    # note that when this script is called from buglist.cgi (rather
    # than show_bug.cgi), it's possible that the product will be changed
    # but that the version and/or component will be set to 
    # "--dont_change--" but still happen to be correct.  in this case,
    # the if statement will incorrectly trigger anyway.  this is a 
    # pretty weird case, and not terribly unreasonable behavior, but 
    # worthy of a comment, perhaps.
    #
196 197
    my $vok = lsearch($::versions{$prod}, $::FORM{'version'}) >= 0;
    my $cok = lsearch($::components{$prod}, $::FORM{'component'}) >= 0;
198 199 200 201 202 203

    my $mok = 1;   # so it won't affect the 'if' statement if milestones aren't used
    if ( Param("usetargetmilestone") ) {
       $mok = lsearch($::target_milestone{$prod}, $::FORM{'target_milestone'}) >= 0;
    }

204 205 206
    # If the product-specific fields need to be verified, or we need to verify
    # whether or not to add the bugs to their new product's group, display
    # a verification form.
207
    if (!$vok || !$cok || !$mok || (Param('usebuggroups') && !defined($::FORM{'addtonewgroup'}))) {
208 209
        $vars->{'form'} = \%::FORM;
        
210
        if (!$vok || !$cok || !$mok) {
211
            $vars->{'verify_fields'} = 1;
212 213 214 215
            my %defaults;
            # We set the defaults to these fields to the old value,
            # if its a valid option, otherwise we use the default where
            # thats appropriate
216
            $vars->{'versions'} = $::versions{$prod};
217 218 219
            if (lsearch($::versions{$prod}, $::FORM{'version'}) != -1) {
                $defaults{'version'} = $::FORM{'version'};
            }
220
            $vars->{'components'} = $::components{$prod};
221 222 223 224
            if (lsearch($::components{$prod}, $::FORM{'component'}) != -1) {
                $defaults{'component'} = $::FORM{'component'};
            }

225 226 227
            if (Param("usetargetmilestone")) {
                $vars->{'use_target_milestone'} = 1;
                $vars->{'milestones'} = $::target_milestone{$prod};
228 229 230 231 232 233 234 235
                if (lsearch($::target_milestone{$prod},
                            $::FORM{'target_milestone'}) != -1) {
                    $defaults{'target_milestone'} = $::FORM{'target_milestone'};
                } else {
                    SendSQL("SELECT defaultmilestone FROM products WHERE " .
                            "product = " . SqlQuote($prod));
                    $defaults{'target_milestone'} = FetchOneColumn();
                }
236
            }
237 238
            else {
                $vars->{'use_target_milestone'} = 0;
terry%netscape.com's avatar
terry%netscape.com committed
239
            }
240
            $vars->{'defaults'} = \%defaults;
241
        }
242 243
        else {
            $vars->{"verify_fields"} = 0;
terry%netscape.com's avatar
terry%netscape.com committed
244
        }
245 246 247 248
        
        $vars->{'verify_bug_group'} = (Param('usebuggroups') 
                                       && !defined($::FORM{'addtonewgroup'}));
        
249
        $template->process("bug/process/verify-new-product.html.tmpl", $vars)
250
          || ThrowTemplateError($template->error());
251
        exit;
terry%netscape.com's avatar
terry%netscape.com committed
252 253 254 255
    }
}


256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278
# Checks that the user is allowed to change the given field.  Actually, right
# now, the rules are pretty simple, and don't look at the field itself very
# much, but that could be enhanced.

my $lastbugid = 0;
my $ownerid;
my $reporterid;
my $qacontactid;

sub CheckCanChangeField {
    my ($f, $bugid, $oldvalue, $newvalue) = (@_);
    if ($f eq "assigned_to" || $f eq "reporter" || $f eq "qa_contact") {
        if ($oldvalue =~ /^\d+$/) {
            if ($oldvalue == 0) {
                $oldvalue = "";
            } else {
                $oldvalue = DBID_to_name($oldvalue);
            }
        }
    }
    if ($oldvalue eq $newvalue) {
        return 1;
    }
279 280 281
    if (trim($oldvalue) eq trim($newvalue)) {
        return 1;
    }
282 283 284
    if ($f =~ /^longdesc/) {
        return 1;
    }
285 286
    if ($f eq "resolution") { # always OK this.  if they really can't,
        return 1;             # it'll flag it when "status" is checked.
287
    }
288 289 290 291 292 293 294 295 296 297 298
    if ($UserInEditGroupSet < 0) {
        $UserInEditGroupSet = UserInGroup("editbugs");
    }
    if ($UserInEditGroupSet) {
        return 1;
    }
    if ($lastbugid != $bugid) {
        SendSQL("SELECT reporter, assigned_to, qa_contact FROM bugs " .
                "WHERE bug_id = $bugid");
        ($reporterid, $ownerid, $qacontactid) = (FetchSQLData());
    }
299 300 301 302 303 304
    # Let reporter change bug status, even if they can't edit bugs.
    # If reporter can't re-open their bug they will just file a duplicate.
    # While we're at it, let them close their own bugs as well.
    if ( ($f eq "bug_status") && ($whoid eq $reporterid) ) {
        return 1;
    }
305 306
    if ($f eq "bug_status" && $newvalue ne $::unconfirmedstate &&
        IsOpenedState($newvalue)) {
307 308 309 310 311 312 313 314 315 316 317 318

        # Hmm.  They are trying to set this bug to some opened state
        # that isn't the UNCONFIRMED state.  Are they in the right
        # group?  Or, has it ever been confirmed?  If not, then this
        # isn't legal.

        if ($UserInCanConfirmGroupSet < 0) {
            $UserInCanConfirmGroupSet = UserInGroup("canconfirm");
        }
        if ($UserInCanConfirmGroupSet) {
            return 1;
        }
319 320 321 322
        SendSQL("SELECT everconfirmed FROM bugs WHERE bug_id = $bugid");
        my $everconfirmed = FetchOneColumn();
        if ($everconfirmed) {
            return 1;
323
        }
324 325 326
    } elsif ($reporterid eq $whoid || $ownerid eq $whoid ||
             $qacontactid eq $whoid) {
        return 1;
327 328
    }
    SendSQL("UNLOCK TABLES");
329 330 331 332 333 334
    $oldvalue = html_quote($oldvalue);
    $newvalue = html_quote($newvalue);
    ThrowUserError("You tried to change the <strong>$f</strong> field 
                    from <em>$oldvalue</em> to <em>$newvalue</em>, 
                    but only the owner or submitter of the bug, or a 
                    sufficiently empowered user, may change that field.");
335 336
}

337 338
# Confirm that the reporter of the current bug can access the bug we are duping to.
sub DuplicateUserConfirm {
339 340 341 342 343
    # if we've already been through here, then exit
    if (defined $::FORM{'confirm_add_duplicate'}) {
        return;
    }

344 345 346 347 348 349 350 351
    my $dupe = trim($::FORM{'id'});
    my $original = trim($::FORM{'dup_id'});
    
    SendSQL("SELECT reporter FROM bugs WHERE bug_id = " . SqlQuote($dupe));
    my $reporter = FetchOneColumn();
    SendSQL("SELECT profiles.groupset FROM profiles WHERE profiles.userid =".SqlQuote($reporter));
    my $reportergroupset = FetchOneColumn();

352
    if (CanSeeBug($original, $reporter, $reportergroupset)) {
353 354 355
        $::FORM{'confirm_add_duplicate'} = "1";
        return;
    }
356 357

    SendSQL("SELECT cclist_accessible FROM bugs WHERE bug_id = $original");
358
    $vars->{'cclist_accessible'} = FetchOneColumn();
359
    
360 361 362
    # Once in this part of the subroutine, the user has not been auto-validated
    # and the duper has not chosen whether or not to add to CC list, so let's
    # ask the duper what he/she wants to do.
363
    
364 365 366 367 368 369
    $vars->{'form'} = \%::FORM;
    $vars->{'original_bug_id'} = $original;
    $vars->{'duplicate_bug_id'} = $dupe;
    
    # Confirm whether or not to add the reporter to the cc: list
    # of the original bug (the one this bug is being duped against).
370
    print "Content-type: text/html\n\n";
371
    $template->process("bug/process/confirm-duplicate.html.tmpl", $vars)
372
      || ThrowTemplateError($template->error());
373 374
    exit;
} # end DuplicateUserConfirm()
375

376
if (defined $::FORM{'id'}) {
377 378 379 380 381 382 383
    # since this means that we were called from show_bug.cgi, now is a good
    # time to do a whole bunch of error checking that can't easily happen when
    # we've been called from buglist.cgi, because buglist.cgi only tweaks
    # values that have been changed instead of submitting all the new values.
    # (XXX those error checks need to happen too, but implementing them 
    # is more work in the current architecture of this script...)
    #
384 385 386 387 388 389 390 391 392 393 394 395
    CheckFormField(\%::FORM, 'rep_platform', \@::legal_platform);
    CheckFormField(\%::FORM, 'priority', \@::legal_priority);
    CheckFormField(\%::FORM, 'bug_severity', \@::legal_severity);
    CheckFormField(\%::FORM, 'component', 
                   \@{$::components{$::FORM{'product'}}});
    CheckFormFieldDefined(\%::FORM, 'bug_file_loc');
    CheckFormFieldDefined(\%::FORM, 'short_desc');
    CheckFormField(\%::FORM, 'product', \@::legal_product);
    CheckFormField(\%::FORM, 'version', 
                   \@{$::versions{$::FORM{'product'}}});
    CheckFormField(\%::FORM, 'op_sys', \@::legal_opsys);
    CheckFormFieldDefined(\%::FORM, 'longdesclength');
terry%netscape.com's avatar
terry%netscape.com committed
396 397
}

398 399 400 401
my $action  = '';
if (defined $::FORM{action}) {
  $action  = trim($::FORM{action});
}
402
if (Param("move-enabled") && $action eq Param("move-button-text")) {
403 404 405 406 407 408 409
  $::FORM{'buglist'} = join (":", @idlist);
  do "move.pl" || die "Error executing move.cgi: $!";
  PutFooter();
  exit;
}


410 411 412 413 414 415 416
$::query = "update bugs\nset";
$::comma = "";
umask(0);

sub DoComma {
    $::query .= "$::comma\n    ";
    $::comma = ",";
terry%netscape.com's avatar
terry%netscape.com committed
417 418
}

419 420 421 422 423 424 425 426 427 428 429 430 431 432
sub DoConfirm {
    if ($UserInEditGroupSet < 0) {
        $UserInEditGroupSet = UserInGroup("editbugs");
    }
    if ($UserInCanConfirmGroupSet < 0) {
        $UserInCanConfirmGroupSet = UserInGroup("canconfirm");
    }
    if ($UserInEditGroupSet || $UserInCanConfirmGroupSet) {
        DoComma();
        $::query .= "everconfirmed = 1";
    }
}


433 434 435 436
sub ChangeStatus {
    my ($str) = (@_);
    if ($str ne $::dontchange) {
        DoComma();
437 438 439 440 441 442 443 444 445 446 447 448 449
        # Ugly, but functional.  We don't want to change Status if we are
        # reasigning non-open bugs via the mass change form.
        if ( ($::FORM{knob} eq 'reassign' || $::FORM{knob} eq 'reassignbycomponent') &&
             ! defined $::FORM{id} && $str eq 'NEW' ) {
            # If we got to here, we're dealing with a reassign from the mass
            # change page.  We don't know (and can't easily figure out) if this
            # bug is open or closed.  If it's closed, we don't want to change
            # its status to NEW.  We have to put some logic into the SQL itself
            # to handle that.
            my @open_state = map(SqlQuote($_), OpenStates());
            my $open_state = join(", ", @open_state);
            $::query .= "bug_status = IF(bug_status IN($open_state), '$str', bug_status)";
        } elsif (IsOpenedState($str)) {
450 451 452 453
            $::query .= "bug_status = IF(everconfirmed = 1, '$str', '$::unconfirmedstate')";
        } else {
            $::query .= "bug_status = '$str'";
        }
454 455 456
        $::FORM{'bug_status'} = $str; # Used later for call to
                                      # CheckCanChangeField to make sure this
                                      # is really kosher.
terry%netscape.com's avatar
terry%netscape.com committed
457 458 459
    }
}

460 461 462 463
sub ChangeResolution {
    my ($str) = (@_);
    if ($str ne $::dontchange) {
        DoComma();
464
        $::query .= "resolution = " . SqlQuote($str);
terry%netscape.com's avatar
terry%netscape.com committed
465 466 467
    }
}

468 469 470 471
# Changing this so that it will process groups from checkboxes instead of
# select lists.  This means that instead of looking for the bit-X values in
# the form, we need to loop through all the bug groups this user has access
# to, and for each one, see if it's selected.
472 473 474 475 476
# In order to make mass changes work correctly, keep a sum of bits for groups
# added, and another one for groups removed, and then let mysql do the bit
# operations
# If the form element isn't present, or the user isn't in the group, leave
# it as-is
477
if($::usergroupset ne '0') {
478 479 480 481 482 483
    my $groupAdd = "0";
    my $groupDel = "0";

    SendSQL("SELECT bit, isactive FROM groups WHERE " .
            "isbuggroup != 0 AND bit & $::usergroupset != 0 ORDER BY bit");
    while (my ($b, $isactive) = FetchSQLData()) {
484 485 486 487 488 489 490 491 492 493 494 495
        # The multiple change page may not show all groups a bug is in
        # (eg product groups when listing more than one product)
        # Only consider groups which were present on the form. We can't do this
        # for single bug changes because non-checked checkboxes aren't present.
        # All the checkboxes should be shown in that case, though, so its not
        # an issue there
        if ($::FORM{'id'} || exists $::FORM{"bit-$b"}) {
            if (!$::FORM{"bit-$b"}) {
                $groupDel .= "+$b";
            } elsif ($::FORM{"bit-$b"} == 1 && $isactive) {
                $groupAdd .= "+$b";
            }
496 497 498 499
        }
    }
    if ($groupAdd ne "0" || $groupDel ne "0") {
        DoComma();
500 501 502
        # mysql < 3.23.5 doesn't support the ~ operator, even though
        # the docs say that it does
        $::query .= "groupset = ((groupset & ($::superusergroupset - ($groupDel))) | ($groupAdd))";
503
    }
504 505
}

506
foreach my $field ("rep_platform", "priority", "bug_severity",          
507
                   "summary", "component", "bug_file_loc", "short_desc",
508
                   "product", "version", "op_sys",
509
                   "target_milestone", "status_whiteboard") {
510 511 512
    if (defined $::FORM{$field}) {
        if ($::FORM{$field} ne $::dontchange) {
            DoComma();
513
            $::query .= "$field = " . SqlQuote(trim($::FORM{$field}));
terry%netscape.com's avatar
terry%netscape.com committed
514 515 516 517
        }
    }
}

518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574
# If this installation uses bug aliases, and the user is changing the alias,
# add this change to the query.
if (Param("usebugaliases") && defined($::FORM{'alias'})) {
    my $alias = trim($::FORM{'alias'});
    
    # Since aliases are unique (like bug numbers), they can only be changed
    # for one bug at a time, so ignore the alias change unless only a single
    # bug is being changed.
    if (scalar(@idlist) == 1) {
        # Validate the alias if the user entered one.
        if ($alias ne "") {
            # Make sure the alias isn't too long.
            if (length($alias) > 20) {
                ThrowUserError("Bug aliases cannot be longer than 20 characters.
                  Please choose a shorter alias.");
            }

            # Make sure the alias is unique.
            my $escaped_alias = SqlQuote($alias);
            SendSQL("SELECT bug_id FROM bugs WHERE alias = $escaped_alias " . 
                    "AND bug_id != $idlist[0]");
            my $id = FetchOneColumn();
            if ($id) {
                my $escaped_alias = html_quote($alias);
                my $bug_link = GetBugLink($id, "Bug $id");
                ThrowUserError("$bug_link has already taken the alias 
                  <em>$escaped_alias</em>.  Please choose another one.");
            }

            # Make sure the alias isn't just a number.
            if ($alias =~ /^\d+$/) {
                ThrowUserError("You gave this bug the alias <em>$alias</em>,
                  but aliases cannot be merely numbers, since they could
                  then be confused with bug IDs.  Please choose another
                  alias containing at least one letter.");
            }

            # Make sure the alias has no commas or spaces.
            if ($alias =~ /[, ]/) {
                my $escaped_alias = html_quote($alias);
                ThrowUserError("The alias you entered, <em>$escaped_alias</em>,
                  contains one or more commas or spaces.  Aliases cannot contain
                  commas or spaces because those characters are used to separate
                  aliases from each other in lists.  Please choose another alias
                  that does not contain commas and spaces.");
            }
        }
        
        # Add the alias change to the query.  If the field contains the blank 
        # value, make the field be NULL to indicate that the bug has no alias.
        # Otherwise, if the field contains a value, update the record 
        # with that value.
        DoComma();
        $::query .= "alias = ";
        $::query .= ($alias eq "") ? "NULL" : SqlQuote($alias);
    }
}
575

576 577
if (defined $::FORM{'qa_contact'}) {
    my $name = trim($::FORM{'qa_contact'});
terry%netscape.com's avatar
terry%netscape.com committed
578
    if ($name ne $::dontchange) {
579 580 581 582 583 584 585 586 587
        my $id = 0;
        if ($name ne "") {
            $id = DBNameToIdAndCheck($name);
        }
        DoComma();
        $::query .= "qa_contact = $id";
    }
}

588

589 590
# If the user is submitting changes from show_bug.cgi for a single bug,
# and that bug is restricted to a group, process the checkboxes that
591
# allowed the user to set whether or not the reporter
592 593
# and cc list can see the bug even if they are not members of all groups 
# to which the bug is restricted.
594
if ( $::FORM{'id'} ) {
595 596 597
    SendSQL("SELECT groupset FROM bugs WHERE bug_id = $::FORM{'id'}");
    my ($groupset) = FetchSQLData();
    if ( $groupset ) {
598 599 600 601 602 603 604 605 606 607 608
        DoComma();
        $::FORM{'reporter_accessible'} = $::FORM{'reporter_accessible'} ? '1' : '0';
        $::query .= "reporter_accessible = $::FORM{'reporter_accessible'}";

        DoComma();
        $::FORM{'cclist_accessible'} = $::FORM{'cclist_accessible'} ? '1' : '0';
        $::query .= "cclist_accessible = $::FORM{'cclist_accessible'}";
    }
}


609
my $duplicate = 0;
610

611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628
# We need to check the addresses involved in a CC change before we touch any bugs.
# What we'll do here is formulate the CC data into two hashes of ID's involved
# in this CC change.  Then those hashes can be used later on for the actual change.
my (%cc_add, %cc_remove);
if (defined $::FORM{newcc} || defined $::FORM{removecc} || defined $::FORM{masscc}) {
    # If masscc is defined, then we came from buglist and need to either add or
    # remove cc's... otherwise, we came from bugform and may need to do both.
    my ($cc_add, $cc_remove) = "";
    if (defined $::FORM{masscc}) {
        if ($::FORM{ccaction} eq 'add') {
            $cc_add = $::FORM{masscc};
        } elsif ($::FORM{ccaction} eq 'remove') {
            $cc_remove = $::FORM{masscc};
        }
    } else {
        $cc_add = $::FORM{newcc};
        # We came from bug_form which uses a select box to determine what cc's
        # need to be removed...
629
        if (defined $::FORM{removecc} && $::FORM{cc}) {
630 631 632 633 634
            $cc_remove = join (",", @{$::MFORM{cc}});
        }
    }

    if ($cc_add) {
635 636
        $cc_add =~ s/[\s,]+/ /g; # Change all delimiters to a single space
        foreach my $person ( split(" ", $cc_add) ) {
637 638 639 640 641
            my $pid = DBNameToIdAndCheck($person);
            $cc_add{$pid} = $person;
        }
    }
    if ($cc_remove) {
642 643
        $cc_remove =~ s/[\s,]+/ /g; # Change all delimiters to a single space
        foreach my $person ( split(" ", $cc_remove) ) {
644 645 646 647 648 649 650
            my $pid = DBNameToIdAndCheck($person);
            $cc_remove{$pid} = $person;
        }
    }
}


651
CheckFormFieldDefined(\%::FORM, 'knob');
652 653 654 655
SWITCH: for ($::FORM{'knob'}) {
    /^none$/ && do {
        last SWITCH;
    };
656 657 658 659 660
    /^confirm$/ && CheckonComment( "confirm" ) && do {
        DoConfirm();
        ChangeStatus('NEW');
        last SWITCH;
    };
661
    /^accept$/ && CheckonComment( "accept" ) && do {
662
        DoConfirm();
663
        ChangeStatus('ASSIGNED');
664 665
        if (Param("musthavemilestoneonaccept") &&
                scalar(@{$::target_milestone{$::FORM{'product'}}}) > 1) {
666 667 668 669
            if (Param("usetargetmilestone")) {
                $requiremilestone = 1;
            }
        }
670 671
        last SWITCH;
    };
672
    /^clearresolution$/ && CheckonComment( "clearresolution" ) && do {
673 674 675
        ChangeResolution('');
        last SWITCH;
    };
676
    /^resolve$/ && CheckonComment( "resolve" ) && do {
677 678
        # Check here, because its the only place we require the resolution
        CheckFormField(\%::FORM, 'resolution', \@::settable_resolution);
679 680 681 682
        ChangeStatus('RESOLVED');
        ChangeResolution($::FORM{'resolution'});
        last SWITCH;
    };
683
    /^reassign$/ && CheckonComment( "reassign" ) && do {
684 685 686
        if ($::FORM{'andconfirm'}) {
            DoConfirm();
        }
687 688
        ChangeStatus('NEW');
        DoComma();
689 690
        if ( !defined$::FORM{'assigned_to'} ||
             trim($::FORM{'assigned_to'}) eq "") {
691 692 693
          ThrowUserError("You cannot reassign to a bug to nobody.  Unless you
                          intentionally cleared out the \"Reassign bug to\" 
                          field, " . Param("browserbugmessage"));
694
        }
695
        my $newid = DBNameToIdAndCheck(trim($::FORM{'assigned_to'}));
696 697 698
        $::query .= "assigned_to = $newid";
        last SWITCH;
    };
699
    /^reassignbycomponent$/  && CheckonComment( "reassignbycomponent" ) && do {
700
        if ($::FORM{'product'} eq $::dontchange) {
701 702
            ThrowUserError("You must specify a product to help determine 
                            the new owner of these bugs.");
703
        }
704
        if ($::FORM{'component'} eq $::dontchange) {
705 706
            ThrowUserError("You must specify a component whose owner 
                            should get assigned these bugs.");
terry%netscape.com's avatar
terry%netscape.com committed
707
        }
708 709 710
        if ($::FORM{'compconfirm'}) {
            DoConfirm();
        }
711 712
        ChangeStatus('NEW');
        SendSQL("select initialowner from components where program=" .
713 714
                SqlQuote($::FORM{'product'}) . " and value=" .
                SqlQuote($::FORM{'component'}));
715 716
        my $newid = FetchOneColumn();
        my $newname = DBID_to_name($newid);
717 718
        DoComma();
        $::query .= "assigned_to = $newid";
719 720 721 722 723
        if (Param("useqacontact")) {
            SendSQL("select initialqacontact from components where program=" .
                    SqlQuote($::FORM{'product'}) .
                    " and value=" . SqlQuote($::FORM{'component'}));
            my $qacontact = FetchOneColumn();
724
            if (defined $qacontact && $qacontact != 0) {
725
                DoComma();
726
                $::query .= "qa_contact = $qacontact";
727 728
            }
        }
729 730
        last SWITCH;
    };   
731
    /^reopen$/  && CheckonComment( "reopen" ) && do {
732
                SendSQL("SELECT resolution FROM bugs WHERE bug_id = $::FORM{'id'}");
733
        ChangeStatus('REOPENED');
734
        ChangeResolution('');
735 736 737
                if (FetchOneColumn() eq 'DUPLICATE') {
                        SendSQL("DELETE FROM duplicates WHERE dupe = $::FORM{'id'}");
                }
738 739
        last SWITCH;
    };
740
    /^verify$/ && CheckonComment( "verify" ) && do {
741 742 743
        ChangeStatus('VERIFIED');
        last SWITCH;
    };
744
    /^close$/ && CheckonComment( "close" ) && do {
745 746 747
        ChangeStatus('CLOSED');
        last SWITCH;
    };
748
    /^duplicate$/ && CheckonComment( "duplicate" ) && do {
749 750
        ChangeStatus('RESOLVED');
        ChangeResolution('DUPLICATE');
751
        CheckFormFieldDefined(\%::FORM,'dup_id');
752
        my $num = trim($::FORM{'dup_id'});
753 754 755
        SendSQL("SELECT bug_id FROM bugs WHERE bug_id = " . SqlQuote($num));
        $num = FetchOneColumn();
        if (!$num) {
756 757
            ThrowUserError("You must specify a valid bug number of which this bug
                            is a duplicate.  The bug has not been changed.")
terry%netscape.com's avatar
terry%netscape.com committed
758
        }
759
        if (!defined($::FORM{'id'}) || $num == $::FORM{'id'}) {
760 761 762
            ThrowUserError("Nice try, $::COOKIE{'Bugzilla_login'}, but it doesn't 
                            really make sense to mark a bug as a duplicate of itself, 
                            does it?");
terry%netscape.com's avatar
terry%netscape.com committed
763
        }
764 765 766 767
        my $checkid = trim($::FORM{'id'});
        SendSQL("SELECT bug_id FROM bugs where bug_id = " .  SqlQuote($checkid));
        $checkid = FetchOneColumn();
        if (!$checkid) {
768
            ThrowUserError("The bug id $::FORM{'id'} is invalid.");
769
        }
770
        $::FORM{'comment'} .= "\n\n*** This bug has been marked as a duplicate of $num ***";
771
        $duplicate = $num;
772

773 774 775
        last SWITCH;
    };
    # default
776 777
    my $escaped_knob = html_quote($::FORM{'knob'});
    ThrowCodeError("Unknown action $escaped_knob!\n");
terry%netscape.com's avatar
terry%netscape.com committed
778 779 780
}


781
if ($#idlist < 0) {
782
    ThrowUserError("You apparently didn't choose any bugs to modify.");
terry%netscape.com's avatar
terry%netscape.com committed
783 784
}

785 786 787 788 789

my @keywordlist;
my %keywordseen;

if ($::FORM{'keywords'}) {
790 791 792 793
    foreach my $keyword (split(/[\s,]+/, $::FORM{'keywords'})) {
        if ($keyword eq '') {
            next;
        }
794
        my $i = GetKeywordIdFromName($keyword);
795
        if (!$i) {
796 797 798
            ThrowUserError("Unknown keyword named <code>" . html_quote($keyword) . 
                           "</code>. <p>The legal keyword names are 
                            <a href=\"describekeywords.cgi\">listed here</a></p>.");
799 800 801 802 803 804 805 806
        }
        if (!$keywordseen{$i}) {
            push(@keywordlist, $i);
            $keywordseen{$i} = 1;
        }
    }
}

807 808
my $keywordaction = $::FORM{'keywordaction'} || "makeexact";

809 810 811 812
if ($::comma eq ""
    && 0 == @keywordlist && $keywordaction ne "makeexact"
    && defined $::FORM{'masscc'} && ! $::FORM{'masscc'}
    ) {
813
    if (!defined $::FORM{'comment'} || $::FORM{'comment'} =~ /^\s*$/) {
814 815
        ThrowUserError("Um, you apparently did not change anything 
                        on the selected bugs.");
terry%netscape.com's avatar
terry%netscape.com committed
816 817 818
    }
}

819
my $basequery = $::query;
820
my $delta_ts;
terry%netscape.com's avatar
terry%netscape.com committed
821

822

823 824
sub SnapShotBug {
    my ($id) = (@_);
825
    SendSQL("select delta_ts, " . join(',', @::log_columns) .
826
            " from bugs where bug_id = $id");
827 828
    my @row = FetchSQLData();
    $delta_ts = shift @row;
829

830
    return @row;
terry%netscape.com's avatar
terry%netscape.com committed
831 832 833
}


834 835 836 837 838 839 840 841 842 843 844 845
sub SnapShotDeps {
    my ($i, $target, $me) = (@_);
    SendSQL("select $target from dependencies where $me = $i order by $target");
    my @list;
    while (MoreSQLData()) {
        push(@list, FetchOneColumn());
    }
    return join(',', @list);
}


my $timestamp;
846
my $bug_changed;
847

848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895
sub FindWrapPoint {
    my ($string, $startpos) = @_;
    if (!$string) { return 0 }
    if (length($string) < $startpos) { return length($string) }
    my $wrappoint = rindex($string, ",", $startpos); # look for comma
    if ($wrappoint < 0) {  # can't find comma
        $wrappoint = rindex($string, " ", $startpos); # look for space
        if ($wrappoint < 0) {  # can't find space
            $wrappoint = rindex($string, "-", $startpos); # look for hyphen
            if ($wrappoint < 0) {  # can't find hyphen
                $wrappoint = $startpos;  # just truncate it
            } else {
                $wrappoint++; # leave hyphen on the left side
            }
        }
    }
    return $wrappoint;
}

sub LogActivityEntry {
    my ($i,$col,$removed,$added) = @_;
    # in the case of CCs, deps, and keywords, there's a possibility that someone
    # might try to add or remove a lot of them at once, which might take more
    # space than the activity table allows.  We'll solve this by splitting it
    # into multiple entries if it's too long.
    while ($removed || $added) {
        my ($removestr, $addstr) = ($removed, $added);
        if (length($removestr) > 254) {
            my $commaposition = FindWrapPoint($removed, 254);
            $removestr = substr($removed,0,$commaposition);
            $removed = substr($removed,$commaposition);
            $removed =~ s/^[,\s]+//; # remove any comma or space
        } else {
            $removed = ""; # no more entries
        }
        if (length($addstr) > 254) {
            my $commaposition = FindWrapPoint($added, 254);
            $addstr = substr($added,0,$commaposition);
            $added = substr($added,$commaposition);
            $added =~ s/^[,\s]+//; # remove any comma or space
        } else {
            $added = ""; # no more entries
        }
        $addstr = SqlQuote($addstr);
        $removestr = SqlQuote($removestr);
        my $fieldid = GetFieldID($col);
        SendSQL("INSERT INTO bugs_activity " .
                "(bug_id,who,bug_when,fieldid,removed,added) VALUES " .
896 897
                "($i,$whoid," . SqlQuote($timestamp) . ",$fieldid,$removestr,$addstr)");
        $bug_changed = 1;
898 899 900
    }
}

901 902 903 904
sub LogDependencyActivity {
    my ($i, $oldstr, $target, $me) = (@_);
    my $newstr = SnapShotDeps($i, $target, $me);
    if ($oldstr ne $newstr) {
905 906
        # Figure out what's really different...
        my ($removed, $added) = DiffStrings($oldstr, $newstr);
907
        LogActivityEntry($i,$target,$removed,$added);
908 909
        # update timestamp on target bug so midairs will be triggered
        SendSQL("UPDATE bugs SET delta_ts=NOW() WHERE bug_id=$i");
910 911 912 913 914
        return 1;
    }
    return 0;
}

915
# this loop iterates once for each bug to be processed (eg when this script
916
# is called with multiple bugs selected from buglist.cgi instead of
917 918
# show_bug.cgi).
#
919
foreach my $id (@idlist) {
920
    my %dependencychanged;
921
    $bug_changed = 0;
922 923
    my $write = "WRITE";        # Might want to make a param to control
                                # whether we do LOW_PRIORITY ...
924
    SendSQL("LOCK TABLES bugs $write, bugs_activity $write, cc $write, " .
925
            "cc AS selectVisible_cc $write, " .
926 927
            "profiles $write, dependencies $write, votes $write, " .
            "keywords $write, longdescs $write, fielddefs $write, " .
928
            "keyworddefs READ, groups READ, attachments READ, products READ");
929
    my @oldvalues = SnapShotBug($id);
930
    my %oldhash;
931 932
    my $i = 0;
    foreach my $col (@::log_columns) {
933 934
        # Consider NULL db entries to be equivalent to the empty string
        $oldvalues[$i] ||= '';
935
        $oldhash{$col} = $oldvalues[$i];
936 937 938 939 940
        if (exists $::FORM{$col}) {
            CheckCanChangeField($col, $id, $oldvalues[$i], $::FORM{$col});
        }
        $i++;
    }
941 942 943 944 945 946 947 948 949
    if ($requiremilestone) {
        my $value = $::FORM{'target_milestone'};
        if (!defined $value || $value eq $::dontchange) {
            $value = $oldhash{'target_milestone'};
        }
        SendSQL("SELECT defaultmilestone FROM products WHERE product = " .
                SqlQuote($oldhash{'product'}));
        if ($value eq FetchOneColumn()) {
            SendSQL("UNLOCK TABLES");
950 951 952 953 954
            ThrowUserError("You must determine a target milestone for bug $id
                            if you are going to accept it.  Part of accepting 
                            a bug is giving an estimate of when it will be fixed.", 
                           undef, 
                           "abort");
955 956
        }
    }   
957
    if (defined $::FORM{'delta_ts'} && $::FORM{'delta_ts'} ne $delta_ts) {
958 959 960 961
        ($vars->{'operations'}) = GetBugActivity($::FORM{'id'}, $::FORM{'delta_ts'});

        $vars->{'start_at'} = $::FORM{'longdesclength'};
        $vars->{'comments'} = GetComments($id);
962

963
        $::FORM{'delta_ts'} = $delta_ts;
964 965 966 967 968 969 970 971
        $vars->{'form'} = \%::FORM;
        
        $vars->{'bug_id'} = $id;
        $vars->{'quoteUrls'} = \&quoteUrls;
        
        SendSQL("UNLOCK TABLES");
        
        # Warn the user about the mid-air collision and ask them what to do.
972
        $template->process("bug/process/midair.html.tmpl", $vars)
973
          || ThrowTemplateError($template->error());
974 975 976
        exit;
    }
        
977 978 979 980
    my %deps;
    if (defined $::FORM{'dependson'}) {
        my $me = "blocked";
        my $target = "dependson";
981
        my %deptree;
982
        for (1..2) {
983
            $deptree{$target} = [];
984 985
            my %seen;
            foreach my $i (split('[\s,]+', $::FORM{$target})) {
986 987
                next if $i eq "";
                
988
                if ($id eq $i) {
989 990 991
                    ThrowUserError("You can't make a bug blocked or dependent on itself.",
                                   undef,
                                   "abort");
992
                }
993
                if (!exists $seen{$i}) {
994
                    push(@{$deptree{$target}}, $i);
995 996 997
                    $seen{$i} = 1;
                }
            }
998 999 1000
            # populate $deps{$target} as first-level deps only.
            # and find remainder of dependency tree in $deptree{$target}
            @{$deps{$target}} = @{$deptree{$target}};
1001 1002 1003
            my @stack = @{$deps{$target}};
            while (@stack) {
                my $i = shift @stack;
1004 1005
                SendSQL("select $target from dependencies where $me = " .
                        SqlQuote($i));
1006 1007
                while (MoreSQLData()) {
                    my $t = FetchOneColumn();
1008 1009 1010 1011
                    # ignore any _current_ dependencies involving this bug,
                    # as they will be overwritten with data from the form.
                    if ($t != $id && !exists $seen{$t}) {
                        push(@{$deptree{$target}}, $t);
1012 1013 1014 1015 1016
                        push @stack, $t;
                        $seen{$t} = 1;
                    }
                }
            }
1017

1018
            if ($me eq 'dependson') {
1019 1020
                my @deps   =  @{$deptree{'dependson'}};
                my @blocks =  @{$deptree{'blocked'}};
1021 1022 1023 1024 1025 1026 1027
                my @union = ();
                my @isect = ();
                my %union = ();
                my %isect = ();
                foreach my $b (@deps, @blocks) { $union{$b}++ && $isect{$b}++ }
                @union = keys %union;
                @isect = keys %isect;
1028
                if (@isect > 0) {
1029 1030
                    my $both;
                    foreach my $i (@isect) {
1031
                       $both = $both . GetBugLink($i, "#" . $i) . " ";
1032
                    }
1033 1034 1035 1036 1037 1038 1039
                    ThrowUserError(qq|Dependency loop detected!<p>
                      The following bug(s) would appear on both the "depends on"
                      and "blocks" parts of the dependency tree if these changes
                      are committed: $both<br>This would create a circular 
                      dependency, which is not allowed.</p>|,
                      undef,
                      "abort");
1040 1041
                }
            }
1042 1043 1044 1045 1046
            my $tmp = $me;
            $me = $target;
            $target = $tmp;
        }
    }
1047

1048 1049 1050 1051 1052 1053
    if (@::legal_keywords) {
        # There are three kinds of "keywordsaction": makeexact, add, delete.
        # For makeexact, we delete everything, and then add our things.
        # For add, we delete things we're adding (to make sure we don't
        # end up having them twice), and then we add them.
        # For delete, we just delete things on the list.
1054
        my $changed = 0;
1055 1056
        if ($keywordaction eq "makeexact") {
            SendSQL("DELETE FROM keywords WHERE bug_id = $id");
1057
            $changed = 1;
1058 1059 1060 1061 1062
        }
        foreach my $keyword (@keywordlist) {
            if ($keywordaction ne "makeexact") {
                SendSQL("DELETE FROM keywords
                         WHERE bug_id = $id AND keywordid = $keyword");
1063
                $changed = 1;
1064 1065 1066 1067
            }
            if ($keywordaction ne "delete") {
                SendSQL("INSERT INTO keywords 
                         (bug_id, keywordid) VALUES ($id, $keyword)");
1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079
                $changed = 1;
            }
        }
        if ($changed) {
            SendSQL("SELECT keyworddefs.name 
                     FROM keyworddefs, keywords
                     WHERE keywords.bug_id = $id
                         AND keyworddefs.id = keywords.keywordid
                     ORDER BY keyworddefs.name");
            my @list;
            while (MoreSQLData()) {
                push(@list, FetchOneColumn());
1080
            }
1081 1082 1083
            SendSQL("UPDATE bugs SET keywords = " .
                    SqlQuote(join(', ', @list)) .
                    " WHERE bug_id = $id");
1084 1085
        }
    }
1086
    my $query = "$basequery\nwhere bug_id = $id";
terry%netscape.com's avatar
terry%netscape.com committed
1087
    
1088 1089
    if ($::comma ne "") {
        SendSQL($query);
terry%netscape.com's avatar
terry%netscape.com committed
1090
    }
1091
    SendSQL("select now()");
1092
    $timestamp = FetchOneColumn();
terry%netscape.com's avatar
terry%netscape.com committed
1093
    
1094
    if (defined $::FORM{'comment'}) {
1095
        AppendComment($id, $::COOKIE{'Bugzilla_login'}, $::FORM{'comment'});
terry%netscape.com's avatar
terry%netscape.com committed
1096 1097
    }
    
1098
    my $removedCcString = "";
1099 1100 1101 1102 1103 1104 1105 1106 1107
    if (defined $::FORM{newcc} || defined $::FORM{removecc} || defined $::FORM{masscc}) {
        # Get the current CC list for this bug
        my %oncc;
        SendSQL("SELECT who FROM cc WHERE bug_id = $id");
        while (MoreSQLData()) {
            $oncc{FetchOneColumn()} = 1;
        }

        my (@added, @removed) = ();
1108 1109 1110 1111 1112 1113
        foreach my $pid (keys %cc_add) {
            # If this person isn't already on the cc list, add them
            if (! $oncc{$pid}) {
                SendSQL("INSERT INTO cc (bug_id, who) VALUES ($id, $pid)");
                push (@added, $cc_add{$pid});
                $oncc{$pid} = 1;
1114 1115
            }
        }
1116 1117 1118 1119 1120 1121
        foreach my $pid (keys %cc_remove) {
            # If the person is on the cc list, remove them
            if ($oncc{$pid}) {
                SendSQL("DELETE FROM cc WHERE bug_id = $id AND who = $pid");
                push (@removed, $cc_remove{$pid});
                $oncc{$pid} = 0;
1122 1123
            }
        }
1124 1125 1126
        # Save off the removedCcString so it can be fed to processmail
        $removedCcString = join (",", @removed);

1127 1128
        # If any changes were found, record it in the activity log
        if (scalar(@removed) || scalar(@added)) {
1129 1130 1131
            my $removed = join(", ", @removed);
            my $added = join(", ", @added);
            LogActivityEntry($id,"cc",$removed,$added);
1132
        }
1133
    }
1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145

    if (defined $::FORM{'dependson'}) {
        my $me = "blocked";
        my $target = "dependson";
        for (1..2) {
            SendSQL("select $target from dependencies where $me = $id order by $target");
            my %snapshot;
            my @oldlist;
            while (MoreSQLData()) {
                push(@oldlist, FetchOneColumn());
            }
            my @newlist = sort {$a <=> $b} @{$deps{$target}};
1146 1147
            @dependencychanged{@oldlist} = 1;
            @dependencychanged{@newlist} = 1;
1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175

            while (0 < @oldlist || 0 < @newlist) {
                if (@oldlist == 0 || (@newlist > 0 &&
                                      $oldlist[0] > $newlist[0])) {
                    $snapshot{$newlist[0]} = SnapShotDeps($newlist[0], $me,
                                                          $target);
                    shift @newlist;
                } elsif (@newlist == 0 || (@oldlist > 0 &&
                                           $newlist[0] > $oldlist[0])) {
                    $snapshot{$oldlist[0]} = SnapShotDeps($oldlist[0], $me,
                                                          $target);
                    shift @oldlist;
                } else {
                    if ($oldlist[0] != $newlist[0]) {
                        die "Error in list comparing code";
                    }
                    shift @oldlist;
                    shift @newlist;
                }
            }
            my @keys = keys(%snapshot);
            if (@keys) {
                my $oldsnap = SnapShotDeps($id, $target, $me);
                SendSQL("delete from dependencies where $me = $id");
                foreach my $i (@{$deps{$target}}) {
                    SendSQL("insert into dependencies ($me, $target) values ($id, $i)");
                }
                foreach my $k (@keys) {
1176
                    LogDependencyActivity($k, $snapshot{$k}, $me, $target);
1177 1178 1179 1180 1181 1182 1183 1184 1185 1186
                }
                LogDependencyActivity($id, $oldsnap, $target, $me);
            }

            my $tmp = $me;
            $me = $target;
            $target = $tmp;
        }
    }

1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248
    # When a bug changes products and the old or new product is associated
    # with a bug group, it may be necessary to remove the bug from the old
    # group or add it to the new one.  There are a very specific series of
    # conditions under which these activities take place, more information
    # about which can be found in comments within the conditionals below.
    if ( 
      # the "usebuggroups" parameter is on, indicating that products
      # are associated with groups of the same name;
      Param('usebuggroups')

      # the user has changed the product to which the bug belongs;
      && defined $::FORM{'product'} 
        && $::FORM{'product'} ne $::dontchange 
          && $::FORM{'product'} ne $oldhash{'product'} 
    ) {
        if (
          # the user wants to add the bug to the new product's group;
          ($::FORM{'addtonewgroup'} eq 'yes' 
            || ($::FORM{'addtonewgroup'} eq 'yesifinold' 
                  && GroupNameToBit($oldhash{'product'}) & $oldhash{'groupset'})) 

          # the new product is associated with a group;
          && GroupExists($::FORM{'product'})

          # the bug is not already in the group; (This can happen when the user
          # goes to the "edit multiple bugs" form with a list of bugs at least
          # one of which is in the new group.  In this situation, the user can
          # simultaneously change the bugs to a new product and move the bugs
          # into that product's group, which happens earlier in this script
          # and thus is already done.  If we didn't check for this, then this
          # situation would cause us to add the bug to the group twice, which
          # would result in the bug being added to a totally different group.)
          && !BugInGroup($id, $::FORM{'product'})

          # the user is a member of the associated group, indicating they
          # are authorized to add bugs to that group, *or* the "usebuggroupsentry"
          # parameter is off, indicating that users can add bugs to a product 
          # regardless of whether or not they belong to its associated group;
          && (UserInGroup($::FORM{'product'}) || !Param('usebuggroupsentry'))

          # the associated group is active, indicating it can accept new bugs;
          && GroupIsActive(GroupNameToBit($::FORM{'product'}))
        ) { 
            # Add the bug to the group associated with its new product.
            my $groupbit = GroupNameToBit($::FORM{'product'});
            SendSQL("UPDATE bugs SET groupset = groupset + $groupbit WHERE bug_id = $id");
        }

        if ( 
          # the old product is associated with a group;
          GroupExists($oldhash{'product'})

          # the bug is a member of that group;
          && BugInGroup($id, $oldhash{'product'}) 
        ) { 
            # Remove the bug from the group associated with its old product.
            my $groupbit = GroupNameToBit($oldhash{'product'});
            SendSQL("UPDATE bugs SET groupset = groupset - $groupbit WHERE bug_id = $id");
        }

    }
  
1249 1250 1251 1252
    # get a snapshot of the newly set values out of the database, 
    # and then generate any necessary bug activity entries by seeing 
    # what has changed since before we wrote out the new values.
    #
1253
    my @newvalues = SnapShotBug($id);
1254

1255 1256 1257 1258 1259 1260
    # for passing to processmail to ensure that when someone is removed
    # from one of these fields, they get notified of that fact (if desired)
    #
    my $origOwner = "";
    my $origQaContact = "";

1261
    foreach my $c (@::log_columns) {
1262 1263
        my $col = $c;           # We modify it, don't want to modify array
                                # values in place.
1264 1265
        my $old = shift @oldvalues;
        my $new = shift @newvalues;
1266 1267 1268 1269 1270 1271
        if (!defined $old) {
            $old = "";
        }
        if (!defined $new) {
            $new = "";
        }
1272
        if ($old ne $new) {
1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285

            # save off the old value for passing to processmail so the old
            # owner can be notified
            #
            if ($col eq 'assigned_to') {
                $old = ($old) ? DBID_to_name($old) : "";
                $new = ($new) ? DBID_to_name($new) : "";
                $origOwner = $old;
            }

            # ditto for the old qa contact
            #
            if ($col eq 'qa_contact') {
1286 1287
                $old = ($old) ? DBID_to_name($old) : "";
                $new = ($new) ? DBID_to_name($new) : "";
1288
                $origQaContact = $old;
terry%netscape.com's avatar
terry%netscape.com committed
1289
            }
1290

1291 1292 1293 1294 1295
            # If this is the keyword field, only record the changes, not everything.
            if ($col eq 'keywords') {
                ($old, $new) = DiffStrings($old, $new);
            }

1296
            if ($col eq 'product') {
1297
                RemoveVotes($id, 0,
1298 1299
                            "This bug has been moved to a different product");
            }
1300
            LogActivityEntry($id,$col,$old,$new);
terry%netscape.com's avatar
terry%netscape.com committed
1301 1302
        }
    }
1303 1304 1305
    if ($bug_changed) {
        SendSQL("UPDATE bugs SET delta_ts = " . SqlQuote($timestamp) . " WHERE bug_id = $id");
    }
1306
    SendSQL("UNLOCK TABLES");
1307

1308
    my @ARGLIST = ();
1309 1310 1311 1312 1313 1314 1315 1316 1317
    if ( $removedCcString ne "" ) {
        push @ARGLIST, ("-forcecc", $removedCcString);
    }
    if ( $origOwner ne "" ) {
        push @ARGLIST, ("-forceowner", $origOwner);
    }
    if ( $origQaContact ne "") { 
        push @ARGLIST, ( "-forceqacontact", $origQaContact);
    }
1318
    push @ARGLIST, ($id, $::COOKIE{'Bugzilla_login'});
1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334
  
    # Send mail to let people know the bug has been changed.  Uses 
    # a special syntax of the "open" and "exec" commands to capture 
    # the output "processmail", which "system" doesn't allow 
    # (i.e. "system ('./processmail', $bugid , $::userid);"), without 
    # the insecurity of running the command through a shell via backticks
    # (i.e. "my $mailresults = `./processmail $bugid $::userid`;").
    $vars->{'mail'} = "";
    open(PMAIL, "-|") or exec('./processmail', @ARGLIST);
    $vars->{'mail'} .= $_ while <PMAIL>;
    close(PMAIL);

    $vars->{'id'} = $id;
    
    # Let the user know the bug was changed and who did and didn't
    # receive email about the change.
1335
    $template->process("bug/process/results.html.tmpl", $vars)
1336 1337
      || ThrowTemplateError($template->error());
    
1338 1339 1340 1341 1342 1343 1344 1345
    if ($duplicate) {
        # Check to see if Reporter of this bug is reporter of Dupe 
        SendSQL("SELECT reporter FROM bugs WHERE bug_id = " . SqlQuote($::FORM{'id'}));
        my $reporter = FetchOneColumn();
        SendSQL("SELECT reporter FROM bugs WHERE bug_id = " . SqlQuote($duplicate) . " and reporter = $reporter");
        my $isreporter = FetchOneColumn();
        SendSQL("SELECT who FROM cc WHERE bug_id = " . SqlQuote($duplicate) . " and who = $reporter");
        my $isoncc = FetchOneColumn();
1346 1347 1348
        unless ($isreporter || $isoncc || ! $::FORM{'confirm_add_duplicate'}) {
            # The reporter is oblivious to the existance of the new bug and is permitted access
            # ... add 'em to the cc (and record activity)
1349
            LogActivityEntry($duplicate,"cc","",DBID_to_name($reporter));
1350 1351
            SendSQL("INSERT INTO cc (who, bug_id) VALUES ($reporter, " . SqlQuote($duplicate) . ")");
        }
1352
        AppendComment($duplicate, $::COOKIE{'Bugzilla_login'}, "*** Bug $::FORM{'id'} has been marked as a duplicate of this bug. ***");
1353
        CheckFormFieldDefined(\%::FORM,'comment');
1354
        SendSQL("INSERT INTO duplicates VALUES ($duplicate, $::FORM{'id'})");
1355 1356 1357 1358 1359 1360 1361 1362 1363 1364
        
        $vars->{'mail'} = "";
        open(PMAIL, "-|") or exec('./processmail', $duplicate, $::COOKIE{'Bugzilla_login'});
        $vars->{'mail'} .= $_ while <PMAIL>;
        close(PMAIL);
        
        $vars->{'id'} = $duplicate;
        $vars->{'type'} = "dupe";
        
        # Let the user know a duplication notation was added to the original bug.
1365
        $template->process("bug/process/results.html.tmpl", $vars)
1366
          || ThrowTemplateError($template->error());
1367 1368
    }

1369
    foreach my $k (keys(%dependencychanged)) {
1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380
        $vars->{'mail'} = "";
        open(PMAIL, "-|") or exec('./processmail', $k, $::COOKIE{'Bugzilla_login'});
        $vars->{'mail'} .= $_ while <PMAIL>;
        close(PMAIL);
        
        $vars->{'id'} = $k;
        $vars->{'type'} = "dep";
        
        # Let the user know we checked to see if we should email notice
        # of this change to users with a relationship to the dependent
        # bug and who did and didn't receive email about it.
1381
        $template->process("bug/process/results.html.tmpl", $vars)
1382
          || ThrowTemplateError($template->error());
1383 1384
    }

terry%netscape.com's avatar
terry%netscape.com committed
1385 1386
}

1387 1388 1389
# Show next bug, if it exists.
if ($::COOKIE{"BUGLIST"} && $::FORM{'id'}) {
    my @bugs = split(/:/, $::COOKIE{"BUGLIST"});
1390
    $vars->{'bug_list'} = \@bugs;
1391 1392 1393 1394 1395
    my $cur = lsearch(\@bugs, $::FORM{"id"});
    if ($cur >= 0 && $cur < $#bugs) {
        my $next_bug = $bugs[$cur + 1];
        if (detaint_natural($next_bug) && CanSeeBug($next_bug)) {
            $::FORM{'id'} = $next_bug;
1396 1397 1398 1399
            
            $vars->{'next_id'} = $next_bug;
            
            # Let the user know we are about to display the next bug in their list.
1400
            $template->process("bug/process/next.html.tmpl", $vars)
1401
              || ThrowTemplateError($template->error());
1402 1403 1404 1405 1406 1407

            show_bug("header is already done");

            exit;
        }
    }
terry%netscape.com's avatar
terry%netscape.com committed
1408
}
1409

1410
# End the response page.
1411
$template->process("bug/navigate.html.tmpl", $vars)
1412
  || ThrowTemplateError($template->error());
1413
$template->process("global/footer.html.tmpl", $vars)
1414
  || ThrowTemplateError($template->error());