process_bug.cgi 51.7 KB
Newer Older
1
#!/usr/bonsaitools/bin/perl -wT
2
# -*- Mode: perl; indent-tabs-mode: nil -*-
terry%netscape.com's avatar
terry%netscape.com committed
3
#
4 5 6 7 8 9 10 11 12 13
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
terry%netscape.com's avatar
terry%netscape.com committed
14
# The Original Code is the Bugzilla Bug Tracking System.
15
#
terry%netscape.com's avatar
terry%netscape.com committed
16
# The Initial Developer of the Original Code is Netscape Communications
17 18 19 20
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
terry%netscape.com's avatar
terry%netscape.com committed
21
# Contributor(s): Terry Weissman <terry@mozilla.org>
22
#                 Dan Mosedale <dmose@mozilla.org>
23
#                 Dave Miller <justdave@syndicomm.com>
24
#                 Christopher Aillon <christopher@aillon.com>
terry%netscape.com's avatar
terry%netscape.com committed
25

26 27 28
use diagnostics;
use strict;

29 30 31
my $UserInEditGroupSet = -1;
my $UserInCanConfirmGroupSet = -1;

32 33
use lib qw(.);

34
require "CGI.pl";
35
use RelationSet;
36 37 38 39 40

# Shut up misguided -w warnings about "used only once":

use vars %::versions,
    %::components,
41
    %::COOKIE,
42
    %::MFORM,
43 44 45 46
    %::legal_keywords,
    %::legal_opsys,
    %::legal_platform,
    %::legal_priority,
47
    %::settable_resolution,
48
    %::target_milestone,
49 50
    %::legal_severity,
    %::superusergroupset;
51

52
my $whoid = confirm_login();
53

54 55
my $requiremilestone = 0;

56 57 58 59 60 61 62 63
######################################################################
# Begin Data/Security Validation
######################################################################

# Create a list of IDs of all bugs being modified in this request.
# This list will either consist of a single bug number from the "id"
# form/URL field or a series of numbers from multiple form/URL fields
# named "id_x" where "x" is the bug number.
64 65
# For each bug being modified, make sure its ID is a valid bug number 
# representing an existing bug that the user is authorized to access.
66 67
my @idlist;
if (defined $::FORM{'id'}) {
68
    ValidateBugID($::FORM{'id'});
69
    push @idlist, $::FORM{'id'};
70
} else {
71 72
    foreach my $i (keys %::FORM) {
        if ($i =~ /^id_([1-9][0-9]*)/) {
73 74 75
            my $id = $1;
            ValidateBugID($id);
            push @idlist, $id;
76
        }
77 78 79
    }
}

80 81 82 83 84
# Make sure there are bugs to process.
scalar(@idlist)
  || DisplayError("You did not select any bugs to modify.")
  && exit;

85 86 87 88 89 90 91 92 93 94
# If we are duping bugs, let's also make sure that we can change 
# the original.  This takes care of issue A on bug 96085.
if (defined $::FORM{'dup_id'} && $::FORM{'knob'} eq "duplicate") {
    ValidateBugID($::FORM{'dup_id'});

    # Also, let's see if the reporter has authorization to see the bug
    # to which we are duping.  If not we need to prompt.
    DuplicateUserConfirm();
}

95 96
ValidateComment($::FORM{'comment'});

97 98 99 100
######################################################################
# End Data/Security Validation
######################################################################

101 102
print "Content-type: text/html\n\n";

103 104
PutHeader ("Bug processed");

105 106
GetVersionTable();

107 108 109
CheckFormFieldDefined(\%::FORM, 'product');
CheckFormFieldDefined(\%::FORM, 'version');
CheckFormFieldDefined(\%::FORM, 'component');
110

111 112 113
# check if target milestone is defined - matthew@zeroknowledge.com
if ( Param("usetargetmilestone") ) {
  CheckFormFieldDefined(\%::FORM, 'target_milestone');
114 115
}

116 117
ConnectToDatabase();

118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144
#
# This function checks if there is a comment required for a specific
# function and tests, if the comment was given.
# If comments are required for functions  is defined by params.
#
sub CheckonComment( $ ) {
    my ($function) = (@_);
    
    # Param is 1 if comment should be added !
    my $ret = Param( "commenton" . $function );

    # Allow without comment in case of undefined Params.
    $ret = 0 unless ( defined( $ret ));

    if( $ret ) {
        if (!defined $::FORM{'comment'} || $::FORM{'comment'} =~ /^\s*$/) {
            # No comment - sorry, action not allowed !
            PuntTryAgain("You have to specify a <b>comment</b> on this " .
                         "change.  Please give some words " .
                         "on the reason for your change.");
        } else {
            $ret = 0;
        }
    }
    return( ! $ret ); # Return val has to be inverted
}

145 146 147 148 149 150 151 152 153
# Figure out whether or not the user is trying to change the product
# (either the "product" variable is not set to "don't change" or the
# user is changing a single bug and has changed the bug's product),
# and make the user verify the version, component, target milestone,
# and bug groups if so.
if ( $::FORM{'id'} ) {
    SendSQL("SELECT product FROM bugs WHERE bug_id = $::FORM{'id'}");
    $::oldproduct = FetchSQLData();
}
154 155 156 157
if ((($::FORM{'id'} && $::FORM{'product'} ne $::oldproduct) 
     || (!$::FORM{'id'} && $::FORM{'product'} ne $::dontchange))
    && CheckonComment( "reassignbycomponent" ))
{
158
    CheckFormField(\%::FORM, 'product', \@::legal_product);
159
    my $prod = $::FORM{'product'};
160 161 162 163 164 165 166 167 168

    # note that when this script is called from buglist.cgi (rather
    # than show_bug.cgi), it's possible that the product will be changed
    # but that the version and/or component will be set to 
    # "--dont_change--" but still happen to be correct.  in this case,
    # the if statement will incorrectly trigger anyway.  this is a 
    # pretty weird case, and not terribly unreasonable behavior, but 
    # worthy of a comment, perhaps.
    #
169 170
    my $vok = lsearch($::versions{$prod}, $::FORM{'version'}) >= 0;
    my $cok = lsearch($::components{$prod}, $::FORM{'component'}) >= 0;
171 172 173 174 175 176

    my $mok = 1;   # so it won't affect the 'if' statement if milestones aren't used
    if ( Param("usetargetmilestone") ) {
       $mok = lsearch($::target_milestone{$prod}, $::FORM{'target_milestone'}) >= 0;
    }

177 178 179 180 181 182 183 184
    # If anything needs to be verified, generate a form for verifying it.
    if (!$vok || !$cok || !$mok || (Param('usebuggroups') && !defined($::FORM{'addtonewgroup'}))) {

        # Start the form.
        print qq|<form action="process_bug.cgi" method="post">\n|;

        # Add all form fields to the form as hidden fields (except those 
        # being verified), so the user's changes are preserved.
185
        foreach my $i (keys %::FORM) {
186
            if ($i ne 'version' && $i ne 'component' && $i ne 'target_milestone') {
187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240
                print qq|<input type="hidden" name="$i" value="| . value_quote($::FORM{$i}) . qq|">\n|;
            }
        }

        # Display UI for verifying the version, component, and target milestone fields.
        if (!$vok || !$cok || !$mok) {
            my ($sectiontitle, $sectiondescription);
            if ( Param('usetargetmilestone') ) {
                $sectiontitle = "Verify Version, Component, Target Milestone";
                $sectiondescription = qq|
                  You are moving the bug(s) to the product <b>$prod</b>, and now the 
                  version, component, and/or target milestone fields are not correct 
                  (or perhaps they were not correct in the first place).  In any case, 
                  please set the correct version, component, and target milestone now:
                |;
            } else {
                $sectiontitle = "Verify Version, Component";
                $sectiondescription = qq|
                  You are moving the bug(s) to the product <b>$prod</b>, and now the 
                  version, and component fields are not correct (or perhaps they were 
                  not correct in the first place).  In any case, please set the correct 
                  version and component now:
                |;
            }

            my $versionmenu = Version_element($::FORM{'version'}, $prod);
            my $componentmenu = Component_element($::FORM{'component'}, $prod);

            print qq|
              <h3>$sectiontitle</h3>

              <p>
                $sectiondescription
              <p>

              <table><tr>
              <td>
                <b>Version:</b><br>
                $versionmenu
              </td>
              <td>
                <b>Component:</b><br>
                $componentmenu
              </td>
            |;

            if ( Param("usetargetmilestone") ) {
                my $milestonemenu = Milestone_element($::FORM{'target_milestone'}, $prod);
                print qq|
                  <td>
                    <b>Target Milestone:</b><br>
                    $milestonemenu
                  </td>
                |;
terry%netscape.com's avatar
terry%netscape.com committed
241
            }
242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264

            print qq|
              </tr></table>
            |;
        }

        # Display UI for determining whether or not to remove the bug from 
        # its old product's group and/or add it to its new product's group.
        if (Param('usebuggroups') && !defined($::FORM{'addtonewgroup'})) {
            print qq|
              <h3>Verify Bug Group</h3>

              <p>
                Do you want to add the bug to its new product's group (if any)?
              </p>

              <p>
                <input type="radio" name="addtonewgroup" value="no"><b>no</b><br>
                <input type="radio" name="addtonewgroup" value="yes"><b>yes</b><br>
                <input type="radio" name="addtonewgroup" value="yesifinold" checked>
                  <b>yes, but only if the bug was in its old product's group</b><br>
              </p>
            |;
terry%netscape.com's avatar
terry%netscape.com committed
265
        }
266 267 268 269 270 271 272 273 274 275

        # End the form.
        print qq|
          <input type="submit" value="Commit">
          </form>
          <hr>
          <a href="query.cgi">Cancel and Return to the Query Page</a>
        |;

        # End the page and stop processing.
276
        PutFooter();
277
        exit;
terry%netscape.com's avatar
terry%netscape.com committed
278 279 280 281
    }
}


282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304
# Checks that the user is allowed to change the given field.  Actually, right
# now, the rules are pretty simple, and don't look at the field itself very
# much, but that could be enhanced.

my $lastbugid = 0;
my $ownerid;
my $reporterid;
my $qacontactid;

sub CheckCanChangeField {
    my ($f, $bugid, $oldvalue, $newvalue) = (@_);
    if ($f eq "assigned_to" || $f eq "reporter" || $f eq "qa_contact") {
        if ($oldvalue =~ /^\d+$/) {
            if ($oldvalue == 0) {
                $oldvalue = "";
            } else {
                $oldvalue = DBID_to_name($oldvalue);
            }
        }
    }
    if ($oldvalue eq $newvalue) {
        return 1;
    }
305 306 307
    if (trim($oldvalue) eq trim($newvalue)) {
        return 1;
    }
308 309 310
    if ($f =~ /^longdesc/) {
        return 1;
    }
311 312
    if ($f eq "resolution") { # always OK this.  if they really can't,
        return 1;             # it'll flag it when "status" is checked.
313
    }
314 315 316 317 318 319 320 321 322 323 324
    if ($UserInEditGroupSet < 0) {
        $UserInEditGroupSet = UserInGroup("editbugs");
    }
    if ($UserInEditGroupSet) {
        return 1;
    }
    if ($lastbugid != $bugid) {
        SendSQL("SELECT reporter, assigned_to, qa_contact FROM bugs " .
                "WHERE bug_id = $bugid");
        ($reporterid, $ownerid, $qacontactid) = (FetchSQLData());
    }
325 326 327 328 329 330
    # Let reporter change bug status, even if they can't edit bugs.
    # If reporter can't re-open their bug they will just file a duplicate.
    # While we're at it, let them close their own bugs as well.
    if ( ($f eq "bug_status") && ($whoid eq $reporterid) ) {
        return 1;
    }
331 332
    if ($f eq "bug_status" && $newvalue ne $::unconfirmedstate &&
        IsOpenedState($newvalue)) {
333 334 335 336 337 338 339 340 341 342 343 344

        # Hmm.  They are trying to set this bug to some opened state
        # that isn't the UNCONFIRMED state.  Are they in the right
        # group?  Or, has it ever been confirmed?  If not, then this
        # isn't legal.

        if ($UserInCanConfirmGroupSet < 0) {
            $UserInCanConfirmGroupSet = UserInGroup("canconfirm");
        }
        if ($UserInCanConfirmGroupSet) {
            return 1;
        }
345 346 347 348
        SendSQL("SELECT everconfirmed FROM bugs WHERE bug_id = $bugid");
        my $everconfirmed = FetchOneColumn();
        if ($everconfirmed) {
            return 1;
349
        }
350 351 352
    } elsif ($reporterid eq $whoid || $ownerid eq $whoid ||
             $qacontactid eq $whoid) {
        return 1;
353 354 355 356
    }
    SendSQL("UNLOCK TABLES");
    $oldvalue = value_quote($oldvalue);
    $newvalue = value_quote($newvalue);
357
    print PuntTryAgain(qq{
358 359 360 361 362 363
Only the owner or submitter of the bug, or a sufficiently
empowered user, may make that change to the $f field.
<TABLE>
<TR><TH ALIGN="right">Old value:</TH><TD>$oldvalue</TD></TR>
<TR><TH ALIGN="right">New value:</TH><TD>$newvalue</TD></TR>
</TABLE>
364
});
365 366 367 368
    PutFooter();
    exit();
}

369 370
# Confirm that the reporter of the current bug can access the bug we are duping to.
sub DuplicateUserConfirm {
371 372 373 374 375
    # if we've already been through here, then exit
    if (defined $::FORM{'confirm_add_duplicate'}) {
        return;
    }

376 377 378 379 380 381 382 383
    my $dupe = trim($::FORM{'id'});
    my $original = trim($::FORM{'dup_id'});
    
    SendSQL("SELECT reporter FROM bugs WHERE bug_id = " . SqlQuote($dupe));
    my $reporter = FetchOneColumn();
    SendSQL("SELECT profiles.groupset FROM profiles WHERE profiles.userid =".SqlQuote($reporter));
    my $reportergroupset = FetchOneColumn();

384
    if (CanSeeBug($original, $reporter, $reportergroupset)) {
385 386 387
        $::FORM{'confirm_add_duplicate'} = "1";
        return;
    }
388 389 390

    SendSQL("SELECT cclist_accessible FROM bugs WHERE bug_id = $original");
    my $cclist_accessible = FetchOneColumn();
391
    
392 393 394
    # Once in this part of the subroutine, the user has not been auto-validated
    # and the duper has not chosen whether or not to add to CC list, so let's
    # ask the duper what he/she wants to do.
395
    
396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422
    # First, will the user gain access to this bug immediately by being CC'd?
    my $reporter_access = $cclist_accessible ? "will immediately" : "might, in the future,";

    print "Content-type: text/html\n\n";
    PutHeader("Duplicate Warning");
    print "<P>
When marking a bug as a duplicate, the reporter of the 
duplicate is normally added to the CC list of the original. 
The permissions on bug #$original (the original) are currently set 
such that the reporter would not normally be able to see it. 
<P><B>Adding the reporter to the CC list of bug #$original 
$reporter_access allow him/her access to view this bug.</B>
Do you wish to do this?</P>
</P>
";
    print "<form method=post>\n\n";

    foreach my $i (keys %::FORM) {
        # Make sure we don't include the username/password fields in the
        # HTML.  If cookies are off, they'll have to reauthenticate after
        # hitting "submit changes anyway".
        # see http://bugzilla.mozilla.org/show_bug.cgi?id=15980
        if ($i !~ /^(Bugzilla|LDAP)_(login|password)$/) {
            my $value = value_quote($::FORM{$i});
            print qq{<input type=hidden name="$i" value="$value">\n};
        }
    }
423

424 425 426 427 428 429 430
    print qq{<p><input type=radio name="confirm_add_duplicate" value="1"> Yes, add the reporter to CC list on bug $original</p>\n};
    print qq{<p><input type=radio name="confirm_add_duplicate" value="0" checked="checked"> No, do not add the reporter to CC list on bug $original</p>\n};
    print qq{\n<p><a href="show_bug.cgi?id=$dupe">Throw away my changes, and go revisit bug $dupe</a>\n};
    print qq{\n<p><input type="submit" value="Submit"></p></form>\n};
    PutFooter();
    exit;
} # end DuplicateUserConfirm()
431

432
if (defined $::FORM{'id'}) {
433 434 435 436 437 438 439
    # since this means that we were called from show_bug.cgi, now is a good
    # time to do a whole bunch of error checking that can't easily happen when
    # we've been called from buglist.cgi, because buglist.cgi only tweaks
    # values that have been changed instead of submitting all the new values.
    # (XXX those error checks need to happen too, but implementing them 
    # is more work in the current architecture of this script...)
    #
440 441 442 443 444 445 446 447 448 449 450 451
    CheckFormField(\%::FORM, 'rep_platform', \@::legal_platform);
    CheckFormField(\%::FORM, 'priority', \@::legal_priority);
    CheckFormField(\%::FORM, 'bug_severity', \@::legal_severity);
    CheckFormField(\%::FORM, 'component', 
                   \@{$::components{$::FORM{'product'}}});
    CheckFormFieldDefined(\%::FORM, 'bug_file_loc');
    CheckFormFieldDefined(\%::FORM, 'short_desc');
    CheckFormField(\%::FORM, 'product', \@::legal_product);
    CheckFormField(\%::FORM, 'version', 
                   \@{$::versions{$::FORM{'product'}}});
    CheckFormField(\%::FORM, 'op_sys', \@::legal_opsys);
    CheckFormFieldDefined(\%::FORM, 'longdesclength');
terry%netscape.com's avatar
terry%netscape.com committed
452 453
}

454 455 456 457 458 459 460 461 462 463 464 465
my $action  = '';
if (defined $::FORM{action}) {
  $action  = trim($::FORM{action});
}
if ($action eq Param("move-button-text")) {
  $::FORM{'buglist'} = join (":", @idlist);
  do "move.pl" || die "Error executing move.cgi: $!";
  PutFooter();
  exit;
}


466 467
# the common updates to all bugs in @idlist start here
#
468 469 470
print "<TITLE>Update Bug " . join(" ", @idlist) . "</TITLE>\n";
if (defined $::FORM{'id'}) {
    navigation_header();
471 472 473 474 475 476 477 478 479 480 481 482
    if (defined $::next_bug) {
        # If there is another bug, then we're going to display it,
        # so check that its a legal bug
        # We need to check that its a number first
        if (!(detaint_natural($::next_bug) && CanSeeBug($::next_bug))) {
            # This isn't OK
            # Rather than error out (which could validly happen if there
            # was a bug in the list whose group was changed in the meantime)
            # just remove references to it
            undef $::next_bug;
        }
    }
483 484
}
print "<HR>\n";
485 486 487 488 489 490 491
$::query = "update bugs\nset";
$::comma = "";
umask(0);

sub DoComma {
    $::query .= "$::comma\n    ";
    $::comma = ",";
terry%netscape.com's avatar
terry%netscape.com committed
492 493
}

494 495 496 497 498 499 500 501 502 503 504 505 506 507
sub DoConfirm {
    if ($UserInEditGroupSet < 0) {
        $UserInEditGroupSet = UserInGroup("editbugs");
    }
    if ($UserInCanConfirmGroupSet < 0) {
        $UserInCanConfirmGroupSet = UserInGroup("canconfirm");
    }
    if ($UserInEditGroupSet || $UserInCanConfirmGroupSet) {
        DoComma();
        $::query .= "everconfirmed = 1";
    }
}


508 509 510 511
sub ChangeStatus {
    my ($str) = (@_);
    if ($str ne $::dontchange) {
        DoComma();
512 513 514 515 516 517 518 519 520 521 522 523 524
        # Ugly, but functional.  We don't want to change Status if we are
        # reasigning non-open bugs via the mass change form.
        if ( ($::FORM{knob} eq 'reassign' || $::FORM{knob} eq 'reassignbycomponent') &&
             ! defined $::FORM{id} && $str eq 'NEW' ) {
            # If we got to here, we're dealing with a reassign from the mass
            # change page.  We don't know (and can't easily figure out) if this
            # bug is open or closed.  If it's closed, we don't want to change
            # its status to NEW.  We have to put some logic into the SQL itself
            # to handle that.
            my @open_state = map(SqlQuote($_), OpenStates());
            my $open_state = join(", ", @open_state);
            $::query .= "bug_status = IF(bug_status IN($open_state), '$str', bug_status)";
        } elsif (IsOpenedState($str)) {
525 526 527 528
            $::query .= "bug_status = IF(everconfirmed = 1, '$str', '$::unconfirmedstate')";
        } else {
            $::query .= "bug_status = '$str'";
        }
529 530 531
        $::FORM{'bug_status'} = $str; # Used later for call to
                                      # CheckCanChangeField to make sure this
                                      # is really kosher.
terry%netscape.com's avatar
terry%netscape.com committed
532 533 534
    }
}

535 536 537 538
sub ChangeResolution {
    my ($str) = (@_);
    if ($str ne $::dontchange) {
        DoComma();
539
        $::query .= "resolution = " . SqlQuote($str);
terry%netscape.com's avatar
terry%netscape.com committed
540 541 542
    }
}

543 544 545 546
# Changing this so that it will process groups from checkboxes instead of
# select lists.  This means that instead of looking for the bit-X values in
# the form, we need to loop through all the bug groups this user has access
# to, and for each one, see if it's selected.
547 548 549 550 551
# In order to make mass changes work correctly, keep a sum of bits for groups
# added, and another one for groups removed, and then let mysql do the bit
# operations
# If the form element isn't present, or the user isn't in the group, leave
# it as-is
552
if($::usergroupset ne '0') {
553 554 555 556 557 558 559 560 561 562 563 564 565 566
    my $groupAdd = "0";
    my $groupDel = "0";

    SendSQL("SELECT bit, isactive FROM groups WHERE " .
            "isbuggroup != 0 AND bit & $::usergroupset != 0 ORDER BY bit");
    while (my ($b, $isactive) = FetchSQLData()) {
        if (!$::FORM{"bit-$b"}) {
            $groupDel .= "+$b";
        } elsif ($::FORM{"bit-$b"} == 1 && $isactive) {
            $groupAdd .= "+$b";
        }
    }
    if ($groupAdd ne "0" || $groupDel ne "0") {
        DoComma();
567 568 569
        # mysql < 3.23.5 doesn't support the ~ operator, even though
        # the docs say that it does
        $::query .= "groupset = ((groupset & ($::superusergroupset - ($groupDel))) | ($groupAdd))";
570
    }
571 572
}

573
foreach my $field ("rep_platform", "priority", "bug_severity",          
574
                   "summary", "component", "bug_file_loc", "short_desc",
575
                   "product", "version", "op_sys",
576
                   "target_milestone", "status_whiteboard") {
577 578 579
    if (defined $::FORM{$field}) {
        if ($::FORM{$field} ne $::dontchange) {
            DoComma();
580
            $::query .= "$field = " . SqlQuote(trim($::FORM{$field}));
terry%netscape.com's avatar
terry%netscape.com committed
581 582 583 584
        }
    }
}

585

586 587
if (defined $::FORM{'qa_contact'}) {
    my $name = trim($::FORM{'qa_contact'});
terry%netscape.com's avatar
terry%netscape.com committed
588
    if ($name ne $::dontchange) {
589 590 591 592 593 594 595 596 597
        my $id = 0;
        if ($name ne "") {
            $id = DBNameToIdAndCheck($name);
        }
        DoComma();
        $::query .= "qa_contact = $id";
    }
}

598

599 600
# If the user is submitting changes from show_bug.cgi for a single bug,
# and that bug is restricted to a group, process the checkboxes that
601
# allowed the user to set whether or not the reporter
602 603
# and cc list can see the bug even if they are not members of all groups 
# to which the bug is restricted.
604
if ( $::FORM{'id'} ) {
605 606 607
    SendSQL("SELECT groupset FROM bugs WHERE bug_id = $::FORM{'id'}");
    my ($groupset) = FetchSQLData();
    if ( $groupset ) {
608 609 610 611 612 613 614 615 616 617 618
        DoComma();
        $::FORM{'reporter_accessible'} = $::FORM{'reporter_accessible'} ? '1' : '0';
        $::query .= "reporter_accessible = $::FORM{'reporter_accessible'}";

        DoComma();
        $::FORM{'cclist_accessible'} = $::FORM{'cclist_accessible'} ? '1' : '0';
        $::query .= "cclist_accessible = $::FORM{'cclist_accessible'}";
    }
}


619
my $duplicate = 0;
620

621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638
# We need to check the addresses involved in a CC change before we touch any bugs.
# What we'll do here is formulate the CC data into two hashes of ID's involved
# in this CC change.  Then those hashes can be used later on for the actual change.
my (%cc_add, %cc_remove);
if (defined $::FORM{newcc} || defined $::FORM{removecc} || defined $::FORM{masscc}) {
    # If masscc is defined, then we came from buglist and need to either add or
    # remove cc's... otherwise, we came from bugform and may need to do both.
    my ($cc_add, $cc_remove) = "";
    if (defined $::FORM{masscc}) {
        if ($::FORM{ccaction} eq 'add') {
            $cc_add = $::FORM{masscc};
        } elsif ($::FORM{ccaction} eq 'remove') {
            $cc_remove = $::FORM{masscc};
        }
    } else {
        $cc_add = $::FORM{newcc};
        # We came from bug_form which uses a select box to determine what cc's
        # need to be removed...
639
        if (defined $::FORM{removecc} && $::FORM{cc}) {
640 641 642 643 644
            $cc_remove = join (",", @{$::MFORM{cc}});
        }
    }

    if ($cc_add) {
645 646
        $cc_add =~ s/[\s,]+/ /g; # Change all delimiters to a single space
        foreach my $person ( split(" ", $cc_add) ) {
647 648 649 650 651
            my $pid = DBNameToIdAndCheck($person);
            $cc_add{$pid} = $person;
        }
    }
    if ($cc_remove) {
652 653
        $cc_remove =~ s/[\s,]+/ /g; # Change all delimiters to a single space
        foreach my $person ( split(" ", $cc_remove) ) {
654 655 656 657 658 659 660
            my $pid = DBNameToIdAndCheck($person);
            $cc_remove{$pid} = $person;
        }
    }
}


661
CheckFormFieldDefined(\%::FORM, 'knob');
662 663 664 665
SWITCH: for ($::FORM{'knob'}) {
    /^none$/ && do {
        last SWITCH;
    };
666 667 668 669 670
    /^confirm$/ && CheckonComment( "confirm" ) && do {
        DoConfirm();
        ChangeStatus('NEW');
        last SWITCH;
    };
671
    /^accept$/ && CheckonComment( "accept" ) && do {
672
        DoConfirm();
673
        ChangeStatus('ASSIGNED');
674 675 676 677 678
        if (Param("musthavemilestoneonaccept")) {
            if (Param("usetargetmilestone")) {
                $requiremilestone = 1;
            }
        }
679 680
        last SWITCH;
    };
681
    /^clearresolution$/ && CheckonComment( "clearresolution" ) && do {
682 683 684
        ChangeResolution('');
        last SWITCH;
    };
685
    /^resolve$/ && CheckonComment( "resolve" ) && do {
686 687
        # Check here, because its the only place we require the resolution
        CheckFormField(\%::FORM, 'resolution', \@::settable_resolution);
688 689 690 691
        ChangeStatus('RESOLVED');
        ChangeResolution($::FORM{'resolution'});
        last SWITCH;
    };
692
    /^reassign$/ && CheckonComment( "reassign" ) && do {
693 694 695
        if ($::FORM{'andconfirm'}) {
            DoConfirm();
        }
696 697
        ChangeStatus('NEW');
        DoComma();
698 699 700 701 702 703
        if ( !defined$::FORM{'assigned_to'} ||
             trim($::FORM{'assigned_to'}) eq "") {
          PuntTryAgain("You cannot reassign to a bug to nobody.  Unless " .
                       "you intentionally cleared out the " .
                       "\"Reassign bug to\" field, " .
                       Param("browserbugmessage"));
704
        }
705 706 707 708
        my $newid = DBNameToIdAndCheck($::FORM{'assigned_to'});
        $::query .= "assigned_to = $newid";
        last SWITCH;
    };
709
    /^reassignbycomponent$/  && CheckonComment( "reassignbycomponent" ) && do {
710
        if ($::FORM{'product'} eq $::dontchange) {
711 712
            PuntTryAgain("You must specify a product to help determine the " .
                         "new owner of these bugs.");
713
        }
714
        if ($::FORM{'component'} eq $::dontchange) {
715 716
            PuntTryAgain("You must specify a component whose owner should " .
                         "get assigned these bugs.");
terry%netscape.com's avatar
terry%netscape.com committed
717
        }
718 719 720
        if ($::FORM{'compconfirm'}) {
            DoConfirm();
        }
721 722
        ChangeStatus('NEW');
        SendSQL("select initialowner from components where program=" .
723 724
                SqlQuote($::FORM{'product'}) . " and value=" .
                SqlQuote($::FORM{'component'}));
725 726
        my $newid = FetchOneColumn();
        my $newname = DBID_to_name($newid);
727 728
        DoComma();
        $::query .= "assigned_to = $newid";
729 730 731 732 733
        if (Param("useqacontact")) {
            SendSQL("select initialqacontact from components where program=" .
                    SqlQuote($::FORM{'product'}) .
                    " and value=" . SqlQuote($::FORM{'component'}));
            my $qacontact = FetchOneColumn();
734
            if (defined $qacontact && $qacontact != 0) {
735
                DoComma();
736
                $::query .= "qa_contact = $qacontact";
737 738
            }
        }
739 740
        last SWITCH;
    };   
741
    /^reopen$/  && CheckonComment( "reopen" ) && do {
742
                SendSQL("SELECT resolution FROM bugs WHERE bug_id = $::FORM{'id'}");
743
        ChangeStatus('REOPENED');
744
        ChangeResolution('');
745 746 747
                if (FetchOneColumn() eq 'DUPLICATE') {
                        SendSQL("DELETE FROM duplicates WHERE dupe = $::FORM{'id'}");
                }
748 749
        last SWITCH;
    };
750
    /^verify$/ && CheckonComment( "verify" ) && do {
751 752 753
        ChangeStatus('VERIFIED');
        last SWITCH;
    };
754
    /^close$/ && CheckonComment( "close" ) && do {
755 756 757
        ChangeStatus('CLOSED');
        last SWITCH;
    };
758
    /^duplicate$/ && CheckonComment( "duplicate" ) && do {
759 760
        ChangeStatus('RESOLVED');
        ChangeResolution('DUPLICATE');
761
        CheckFormFieldDefined(\%::FORM,'dup_id');
762
        my $num = trim($::FORM{'dup_id'});
763 764 765
        SendSQL("SELECT bug_id FROM bugs WHERE bug_id = " . SqlQuote($num));
        $num = FetchOneColumn();
        if (!$num) {
766 767
            PuntTryAgain("You must specify a valid bug number of which this bug " .
                         "is a duplicate.  The bug has not been changed.")
terry%netscape.com's avatar
terry%netscape.com committed
768
        }
769
        if (!defined($::FORM{'id'}) || $num == $::FORM{'id'}) {
770
            PuntTryAgain("Nice try, $::COOKIE{'Bugzilla_login'}.  But it doesn't really ".
771 772
                         "make sense to mark a bug as a duplicate of " .
                         "itself, does it?");
terry%netscape.com's avatar
terry%netscape.com committed
773
        }
774 775 776 777 778 779 780
        my $checkid = trim($::FORM{'id'});
        SendSQL("SELECT bug_id FROM bugs where bug_id = " .  SqlQuote($checkid));
        $checkid = FetchOneColumn();
        if (!$checkid) {
            PuntTryAgain("The bug id $::FORM{'id'} is invalid. Please reload this bug ".
                         "and try again.");
        }
781
        $::FORM{'comment'} .= "\n\n*** This bug has been marked as a duplicate of $num ***";
782
        $duplicate = $num;
783

784 785 786 787
        last SWITCH;
    };
    # default
    print "Unknown action $::FORM{'knob'}!\n";
788
    PutFooter();
789
    exit;
terry%netscape.com's avatar
terry%netscape.com committed
790 791 792
}


793
if ($#idlist < 0) {
794
    PuntTryAgain("You apparently didn't choose any bugs to modify.");
terry%netscape.com's avatar
terry%netscape.com committed
795 796
}

797 798 799 800 801

my @keywordlist;
my %keywordseen;

if ($::FORM{'keywords'}) {
802 803 804 805
    foreach my $keyword (split(/[\s,]+/, $::FORM{'keywords'})) {
        if ($keyword eq '') {
            next;
        }
806
        my $i = GetKeywordIdFromName($keyword);
807
        if (!$i) {
808 809
            PuntTryAgain("Unknown keyword named <code>" .
                         html_quote($keyword) . "</code>. " .
810 811 812
                         "<P>The legal keyword names are " .
                         "<A HREF=describekeywords.cgi>" .
                         "listed here</A>.");
813 814 815 816 817 818 819 820
        }
        if (!$keywordseen{$i}) {
            push(@keywordlist, $i);
            $keywordseen{$i} = 1;
        }
    }
}

821 822
my $keywordaction = $::FORM{'keywordaction'} || "makeexact";

823 824 825 826
if ($::comma eq ""
    && 0 == @keywordlist && $keywordaction ne "makeexact"
    && defined $::FORM{'masscc'} && ! $::FORM{'masscc'}
    ) {
827
    if (!defined $::FORM{'comment'} || $::FORM{'comment'} =~ /^\s*$/) {
828 829
        PuntTryAgain("Um, you apparently did not change anything on the " .
                     "selected bugs.");
terry%netscape.com's avatar
terry%netscape.com committed
830 831 832
    }
}

833
my $basequery = $::query;
834
my $delta_ts;
terry%netscape.com's avatar
terry%netscape.com committed
835

836

837 838
sub SnapShotBug {
    my ($id) = (@_);
839
    SendSQL("select delta_ts, " . join(',', @::log_columns) .
840
            " from bugs where bug_id = $id");
841 842
    my @row = FetchSQLData();
    $delta_ts = shift @row;
843

844
    return @row;
terry%netscape.com's avatar
terry%netscape.com committed
845 846 847
}


848 849 850 851 852 853 854 855 856 857 858 859
sub SnapShotDeps {
    my ($i, $target, $me) = (@_);
    SendSQL("select $target from dependencies where $me = $i order by $target");
    my @list;
    while (MoreSQLData()) {
        push(@list, FetchOneColumn());
    }
    return join(',', @list);
}


my $timestamp;
860
my $bug_changed;
861

862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909
sub FindWrapPoint {
    my ($string, $startpos) = @_;
    if (!$string) { return 0 }
    if (length($string) < $startpos) { return length($string) }
    my $wrappoint = rindex($string, ",", $startpos); # look for comma
    if ($wrappoint < 0) {  # can't find comma
        $wrappoint = rindex($string, " ", $startpos); # look for space
        if ($wrappoint < 0) {  # can't find space
            $wrappoint = rindex($string, "-", $startpos); # look for hyphen
            if ($wrappoint < 0) {  # can't find hyphen
                $wrappoint = $startpos;  # just truncate it
            } else {
                $wrappoint++; # leave hyphen on the left side
            }
        }
    }
    return $wrappoint;
}

sub LogActivityEntry {
    my ($i,$col,$removed,$added) = @_;
    # in the case of CCs, deps, and keywords, there's a possibility that someone
    # might try to add or remove a lot of them at once, which might take more
    # space than the activity table allows.  We'll solve this by splitting it
    # into multiple entries if it's too long.
    while ($removed || $added) {
        my ($removestr, $addstr) = ($removed, $added);
        if (length($removestr) > 254) {
            my $commaposition = FindWrapPoint($removed, 254);
            $removestr = substr($removed,0,$commaposition);
            $removed = substr($removed,$commaposition);
            $removed =~ s/^[,\s]+//; # remove any comma or space
        } else {
            $removed = ""; # no more entries
        }
        if (length($addstr) > 254) {
            my $commaposition = FindWrapPoint($added, 254);
            $addstr = substr($added,0,$commaposition);
            $added = substr($added,$commaposition);
            $added =~ s/^[,\s]+//; # remove any comma or space
        } else {
            $added = ""; # no more entries
        }
        $addstr = SqlQuote($addstr);
        $removestr = SqlQuote($removestr);
        my $fieldid = GetFieldID($col);
        SendSQL("INSERT INTO bugs_activity " .
                "(bug_id,who,bug_when,fieldid,removed,added) VALUES " .
910 911
                "($i,$whoid," . SqlQuote($timestamp) . ",$fieldid,$removestr,$addstr)");
        $bug_changed = 1;
912 913 914
    }
}

915 916 917 918
sub LogDependencyActivity {
    my ($i, $oldstr, $target, $me) = (@_);
    my $newstr = SnapShotDeps($i, $target, $me);
    if ($oldstr ne $newstr) {
919 920
        # Figure out what's really different...
        my ($removed, $added) = DiffStrings($oldstr, $newstr);
921
        LogActivityEntry($i,$target,$removed,$added);
922 923
        # update timestamp on target bug so midairs will be triggered
        SendSQL("UPDATE bugs SET delta_ts=NOW() WHERE bug_id=$i");
924 925 926 927 928
        return 1;
    }
    return 0;
}

929
# this loop iterates once for each bug to be processed (eg when this script
930
# is called with multiple bugs selected from buglist.cgi instead of
931 932
# show_bug.cgi).
#
933
foreach my $id (@idlist) {
934
    my %dependencychanged;
935
    $bug_changed = 0;
936 937
    my $write = "WRITE";        # Might want to make a param to control
                                # whether we do LOW_PRIORITY ...
938
    SendSQL("LOCK TABLES bugs $write, bugs_activity $write, cc $write, " .
939
            "cc AS selectVisible_cc $write, " .
940 941
            "profiles $write, dependencies $write, votes $write, " .
            "keywords $write, longdescs $write, fielddefs $write, " .
942
            "keyworddefs READ, groups READ, attachments READ, products READ");
943
    my @oldvalues = SnapShotBug($id);
944
    my %oldhash;
945 946
    my $i = 0;
    foreach my $col (@::log_columns) {
947
        $oldhash{$col} = $oldvalues[$i];
948 949 950 951 952
        if (exists $::FORM{$col}) {
            CheckCanChangeField($col, $id, $oldvalues[$i], $::FORM{$col});
        }
        $i++;
    }
953 954 955 956 957 958 959 960 961 962 963 964 965 966 967
    if ($requiremilestone) {
        my $value = $::FORM{'target_milestone'};
        if (!defined $value || $value eq $::dontchange) {
            $value = $oldhash{'target_milestone'};
        }
        SendSQL("SELECT defaultmilestone FROM products WHERE product = " .
                SqlQuote($oldhash{'product'}));
        if ($value eq FetchOneColumn()) {
            SendSQL("UNLOCK TABLES");
            PuntTryAgain("You must determine a target milestone for bug $id " .
                         "if you are going to accept it.  (Part of " .
                         "accepting a bug is giving an estimate of when it " .
                         "will be fixed.)");
        }
    }   
968 969 970 971 972 973 974
    if (defined $::FORM{'delta_ts'} && $::FORM{'delta_ts'} ne $delta_ts) {
        print "
<H1>Mid-air collision detected!</H1>
Someone else has made changes to this bug at the same time you were trying to.
The changes made were:
<p>
";
975
        DumpBugActivity($id, $::FORM{'delta_ts'});
976
        my $longdesc = GetLongDescriptionAsHTML($id);
977
        my $longchanged = 0;
978

979 980
        if (length($longdesc) > $::FORM{'longdesclength'}) {
            $longchanged = 1;
981 982 983
            print "<P>Added text to the long description:<blockquote>";
            print substr($longdesc, $::FORM{'longdesclength'});
            print "</blockquote>\n";
984 985 986 987 988 989
        }
        SendSQL("unlock tables");
        print "You have the following choices: <ul>\n";
        $::FORM{'delta_ts'} = $delta_ts;
        print "<li><form method=post>";
        foreach my $i (keys %::FORM) {
990 991 992 993 994 995 996 997
            # Make sure we don't include the username/password fields in the
            # HTML.  If cookies are off, they'll have to reauthenticate after
            # hitting "submit changes anyway".
            # see http://bugzilla.mozilla.org/show_bug.cgi?id=15980
            if ($i !~ /^(Bugzilla|LDAP)_(login|password)$/) {
              my $value = value_quote($::FORM{$i});
              print qq{<input type=hidden name="$i" value="$value">\n};
            }
998 999
        }
        print qq{<input type=submit value="Submit my changes anyway">\n};
cyeh%bluemartini.com's avatar
cyeh%bluemartini.com committed
1000 1001 1002 1003
        print " This will cause all of the above changes to be overwritten";
        if ($longchanged) {
            print ", except for the changes to the description";
        }
1004
        print qq{.</form>\n<li><a href="show_bug.cgi?id=$id">Throw away my changes, and go revisit bug $id</a></ul>\n};
1005
        PutFooter();
1006 1007 1008
        exit;
    }
        
1009 1010 1011 1012 1013 1014 1015 1016 1017 1018
    my %deps;
    if (defined $::FORM{'dependson'}) {
        my $me = "blocked";
        my $target = "dependson";
        for (1..2) {
            $deps{$target} = [];
            my %seen;
            foreach my $i (split('[\s,]+', $::FORM{$target})) {
                if ($i eq "") {
                    next;
1019
                }
1020

1021 1022 1023
                my $orig = $i;
                if (!detaint_natural($i)) {
                    PuntTryAgain("$orig is not a legal bug number");
1024
                }
1025 1026 1027

                # Don't use CanSeeBug, since we want to keep deps to bugs a
                # user can't see
1028 1029 1030 1031
                SendSQL("select bug_id from bugs where bug_id = " .
                        SqlQuote($i));
                my $comp = FetchOneColumn();
                if ($comp ne $i) {
1032
                    PuntTryAgain("$i is not a legal bug number");
1033
                }
1034 1035 1036
                if ($id eq $i) {
                    PuntTryAgain("You can't make a bug blocked or dependent on itself.");
                }
1037 1038 1039 1040 1041 1042 1043 1044
                if (!exists $seen{$i}) {
                    push(@{$deps{$target}}, $i);
                    $seen{$i} = 1;
                }
            }
            my @stack = @{$deps{$target}};
            while (@stack) {
                my $i = shift @stack;
1045 1046
                SendSQL("select $target from dependencies where $me = " .
                        SqlQuote($i));
1047 1048 1049
                while (MoreSQLData()) {
                    my $t = FetchOneColumn();
                    if ($t == $id) {
1050 1051 1052 1053
                        PuntTryAgain("Dependency loop detected!<P>" .
                                     "The change you are making to " .
                                     "dependencies has caused a circular " .
                                     "dependency chain.");
1054 1055 1056 1057 1058 1059 1060
                    }
                    if (!exists $seen{$t}) {
                        push @stack, $t;
                        $seen{$t} = 1;
                    }
                }
            }
1061

1062
            if ($me eq 'dependson') {
1063 1064 1065 1066 1067 1068 1069 1070 1071
                my @deps   =  @{$deps{'dependson'}};
                my @blocks =  @{$deps{'blocked'}};
                my @union = ();
                my @isect = ();
                my %union = ();
                my %isect = ();
                foreach my $b (@deps, @blocks) { $union{$b}++ && $isect{$b}++ }
                @union = keys %union;
                @isect = keys %isect;
1072
                if (@isect > 0) {
1073 1074
                    my $both;
                    foreach my $i (@isect) {
1075
                       $both = $both . "#" . $i . " ";
1076 1077 1078 1079 1080 1081
                    }
                    PuntTryAgain("Dependency loop detected!<P>" .
                                 "This bug can't be both blocked and dependent " .
                                 "on bug "  . $both . "!");
                }
            }
1082 1083 1084 1085 1086
            my $tmp = $me;
            $me = $target;
            $target = $tmp;
        }
    }
1087

1088 1089 1090 1091 1092 1093
    if (@::legal_keywords) {
        # There are three kinds of "keywordsaction": makeexact, add, delete.
        # For makeexact, we delete everything, and then add our things.
        # For add, we delete things we're adding (to make sure we don't
        # end up having them twice), and then we add them.
        # For delete, we just delete things on the list.
1094
        my $changed = 0;
1095 1096
        if ($keywordaction eq "makeexact") {
            SendSQL("DELETE FROM keywords WHERE bug_id = $id");
1097
            $changed = 1;
1098 1099 1100 1101 1102
        }
        foreach my $keyword (@keywordlist) {
            if ($keywordaction ne "makeexact") {
                SendSQL("DELETE FROM keywords
                         WHERE bug_id = $id AND keywordid = $keyword");
1103
                $changed = 1;
1104 1105 1106 1107
            }
            if ($keywordaction ne "delete") {
                SendSQL("INSERT INTO keywords 
                         (bug_id, keywordid) VALUES ($id, $keyword)");
1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119
                $changed = 1;
            }
        }
        if ($changed) {
            SendSQL("SELECT keyworddefs.name 
                     FROM keyworddefs, keywords
                     WHERE keywords.bug_id = $id
                         AND keyworddefs.id = keywords.keywordid
                     ORDER BY keyworddefs.name");
            my @list;
            while (MoreSQLData()) {
                push(@list, FetchOneColumn());
1120
            }
1121 1122 1123
            SendSQL("UPDATE bugs SET keywords = " .
                    SqlQuote(join(', ', @list)) .
                    " WHERE bug_id = $id");
1124 1125
        }
    }
1126
    my $query = "$basequery\nwhere bug_id = $id";
terry%netscape.com's avatar
terry%netscape.com committed
1127
    
1128 1129 1130 1131
# print "<PRE>$query</PRE>\n";

    if ($::comma ne "") {
        SendSQL($query);
terry%netscape.com's avatar
terry%netscape.com committed
1132
    }
1133
    SendSQL("select now()");
1134
    $timestamp = FetchOneColumn();
terry%netscape.com's avatar
terry%netscape.com committed
1135
    
1136
    if (defined $::FORM{'comment'}) {
1137
        AppendComment($id, $::COOKIE{'Bugzilla_login'}, $::FORM{'comment'});
terry%netscape.com's avatar
terry%netscape.com committed
1138 1139
    }
    
1140
    my $removedCcString = "";
1141 1142 1143 1144 1145 1146 1147 1148 1149
    if (defined $::FORM{newcc} || defined $::FORM{removecc} || defined $::FORM{masscc}) {
        # Get the current CC list for this bug
        my %oncc;
        SendSQL("SELECT who FROM cc WHERE bug_id = $id");
        while (MoreSQLData()) {
            $oncc{FetchOneColumn()} = 1;
        }

        my (@added, @removed) = ();
1150 1151 1152 1153 1154 1155
        foreach my $pid (keys %cc_add) {
            # If this person isn't already on the cc list, add them
            if (! $oncc{$pid}) {
                SendSQL("INSERT INTO cc (bug_id, who) VALUES ($id, $pid)");
                push (@added, $cc_add{$pid});
                $oncc{$pid} = 1;
1156 1157
            }
        }
1158 1159 1160 1161 1162 1163
        foreach my $pid (keys %cc_remove) {
            # If the person is on the cc list, remove them
            if ($oncc{$pid}) {
                SendSQL("DELETE FROM cc WHERE bug_id = $id AND who = $pid");
                push (@removed, $cc_remove{$pid});
                $oncc{$pid} = 0;
1164 1165
            }
        }
1166 1167 1168
        # Save off the removedCcString so it can be fed to processmail
        $removedCcString = join (",", @removed);

1169 1170
        # If any changes were found, record it in the activity log
        if (scalar(@removed) || scalar(@added)) {
1171 1172 1173
            my $removed = join(", ", @removed);
            my $added = join(", ", @added);
            LogActivityEntry($id,"cc",$removed,$added);
1174
        }
1175
    }
1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187

    if (defined $::FORM{'dependson'}) {
        my $me = "blocked";
        my $target = "dependson";
        for (1..2) {
            SendSQL("select $target from dependencies where $me = $id order by $target");
            my %snapshot;
            my @oldlist;
            while (MoreSQLData()) {
                push(@oldlist, FetchOneColumn());
            }
            my @newlist = sort {$a <=> $b} @{$deps{$target}};
1188 1189
            @dependencychanged{@oldlist} = 1;
            @dependencychanged{@newlist} = 1;
1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217

            while (0 < @oldlist || 0 < @newlist) {
                if (@oldlist == 0 || (@newlist > 0 &&
                                      $oldlist[0] > $newlist[0])) {
                    $snapshot{$newlist[0]} = SnapShotDeps($newlist[0], $me,
                                                          $target);
                    shift @newlist;
                } elsif (@newlist == 0 || (@oldlist > 0 &&
                                           $newlist[0] > $oldlist[0])) {
                    $snapshot{$oldlist[0]} = SnapShotDeps($oldlist[0], $me,
                                                          $target);
                    shift @oldlist;
                } else {
                    if ($oldlist[0] != $newlist[0]) {
                        die "Error in list comparing code";
                    }
                    shift @oldlist;
                    shift @newlist;
                }
            }
            my @keys = keys(%snapshot);
            if (@keys) {
                my $oldsnap = SnapShotDeps($id, $target, $me);
                SendSQL("delete from dependencies where $me = $id");
                foreach my $i (@{$deps{$target}}) {
                    SendSQL("insert into dependencies ($me, $target) values ($id, $i)");
                }
                foreach my $k (@keys) {
1218
                    LogDependencyActivity($k, $snapshot{$k}, $me, $target);
1219 1220 1221 1222 1223 1224 1225 1226 1227 1228
                }
                LogDependencyActivity($id, $oldsnap, $target, $me);
            }

            my $tmp = $me;
            $me = $target;
            $target = $tmp;
        }
    }

1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291
    # When a bug changes products and the old or new product is associated
    # with a bug group, it may be necessary to remove the bug from the old
    # group or add it to the new one.  There are a very specific series of
    # conditions under which these activities take place, more information
    # about which can be found in comments within the conditionals below.
    if ( 
      # the "usebuggroups" parameter is on, indicating that products
      # are associated with groups of the same name;
      Param('usebuggroups')

      # the user has changed the product to which the bug belongs;
      && defined $::FORM{'product'} 
        && $::FORM{'product'} ne $::dontchange 
          && $::FORM{'product'} ne $oldhash{'product'} 
    ) {
        if (
          # the user wants to add the bug to the new product's group;
          ($::FORM{'addtonewgroup'} eq 'yes' 
            || ($::FORM{'addtonewgroup'} eq 'yesifinold' 
                  && GroupNameToBit($oldhash{'product'}) & $oldhash{'groupset'})) 

          # the new product is associated with a group;
          && GroupExists($::FORM{'product'})

          # the bug is not already in the group; (This can happen when the user
          # goes to the "edit multiple bugs" form with a list of bugs at least
          # one of which is in the new group.  In this situation, the user can
          # simultaneously change the bugs to a new product and move the bugs
          # into that product's group, which happens earlier in this script
          # and thus is already done.  If we didn't check for this, then this
          # situation would cause us to add the bug to the group twice, which
          # would result in the bug being added to a totally different group.)
          && !BugInGroup($id, $::FORM{'product'})

          # the user is a member of the associated group, indicating they
          # are authorized to add bugs to that group, *or* the "usebuggroupsentry"
          # parameter is off, indicating that users can add bugs to a product 
          # regardless of whether or not they belong to its associated group;
          && (UserInGroup($::FORM{'product'}) || !Param('usebuggroupsentry'))

          # the associated group is active, indicating it can accept new bugs;
          && GroupIsActive(GroupNameToBit($::FORM{'product'}))
        ) { 
            # Add the bug to the group associated with its new product.
            my $groupbit = GroupNameToBit($::FORM{'product'});
            SendSQL("UPDATE bugs SET groupset = groupset + $groupbit WHERE bug_id = $id");
        }

        if ( 
          # the old product is associated with a group;
          GroupExists($oldhash{'product'})

          # the bug is a member of that group;
          && BugInGroup($id, $oldhash{'product'}) 
        ) { 
            # Remove the bug from the group associated with its old product.
            my $groupbit = GroupNameToBit($oldhash{'product'});
            SendSQL("UPDATE bugs SET groupset = groupset - $groupbit WHERE bug_id = $id");
        }

        print qq|</p>|;
    }
  
1292 1293 1294 1295
    # get a snapshot of the newly set values out of the database, 
    # and then generate any necessary bug activity entries by seeing 
    # what has changed since before we wrote out the new values.
    #
1296
    my @newvalues = SnapShotBug($id);
1297

1298 1299 1300 1301 1302 1303
    # for passing to processmail to ensure that when someone is removed
    # from one of these fields, they get notified of that fact (if desired)
    #
    my $origOwner = "";
    my $origQaContact = "";

1304
    foreach my $c (@::log_columns) {
1305 1306
        my $col = $c;           # We modify it, don't want to modify array
                                # values in place.
1307 1308
        my $old = shift @oldvalues;
        my $new = shift @newvalues;
1309 1310 1311 1312 1313 1314
        if (!defined $old) {
            $old = "";
        }
        if (!defined $new) {
            $new = "";
        }
1315
        if ($old ne $new) {
1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328

            # save off the old value for passing to processmail so the old
            # owner can be notified
            #
            if ($col eq 'assigned_to') {
                $old = ($old) ? DBID_to_name($old) : "";
                $new = ($new) ? DBID_to_name($new) : "";
                $origOwner = $old;
            }

            # ditto for the old qa contact
            #
            if ($col eq 'qa_contact') {
1329 1330
                $old = ($old) ? DBID_to_name($old) : "";
                $new = ($new) ? DBID_to_name($new) : "";
1331
                $origQaContact = $old;
terry%netscape.com's avatar
terry%netscape.com committed
1332
            }
1333

1334 1335 1336 1337 1338
            # If this is the keyword field, only record the changes, not everything.
            if ($col eq 'keywords') {
                ($old, $new) = DiffStrings($old, $new);
            }

1339
            if ($col eq 'product') {
1340
                RemoveVotes($id, 0,
1341 1342
                            "This bug has been moved to a different product");
            }
1343
            LogActivityEntry($id,$col,$old,$new);
terry%netscape.com's avatar
terry%netscape.com committed
1344 1345
        }
    }
1346 1347 1348
    if ($bug_changed) {
        SendSQL("UPDATE bugs SET delta_ts = " . SqlQuote($timestamp) . " WHERE bug_id = $id");
    }
1349
    print "<TABLE BORDER=1><TD><H2>Changes to bug $id submitted</H2>\n";
1350
    SendSQL("unlock tables");
1351

1352
    my @ARGLIST = ();
1353 1354 1355 1356 1357 1358 1359 1360 1361
    if ( $removedCcString ne "" ) {
        push @ARGLIST, ("-forcecc", $removedCcString);
    }
    if ( $origOwner ne "" ) {
        push @ARGLIST, ("-forceowner", $origOwner);
    }
    if ( $origQaContact ne "") { 
        push @ARGLIST, ( "-forceqacontact", $origQaContact);
    }
1362
    push @ARGLIST, ($id, $::COOKIE{'Bugzilla_login'});
1363
    system ("./processmail",@ARGLIST);
1364

1365
    print "<TD><A HREF=\"show_bug.cgi?id=$id\">Back To BUG# $id</A></TABLE>\n";
1366

1367 1368 1369 1370 1371 1372 1373 1374
    if ($duplicate) {
        # Check to see if Reporter of this bug is reporter of Dupe 
        SendSQL("SELECT reporter FROM bugs WHERE bug_id = " . SqlQuote($::FORM{'id'}));
        my $reporter = FetchOneColumn();
        SendSQL("SELECT reporter FROM bugs WHERE bug_id = " . SqlQuote($duplicate) . " and reporter = $reporter");
        my $isreporter = FetchOneColumn();
        SendSQL("SELECT who FROM cc WHERE bug_id = " . SqlQuote($duplicate) . " and who = $reporter");
        my $isoncc = FetchOneColumn();
1375 1376 1377
        unless ($isreporter || $isoncc || ! $::FORM{'confirm_add_duplicate'}) {
            # The reporter is oblivious to the existance of the new bug and is permitted access
            # ... add 'em to the cc (and record activity)
1378
            LogActivityEntry($duplicate,"cc","",DBID_to_name($reporter));
1379 1380
            SendSQL("INSERT INTO cc (who, bug_id) VALUES ($reporter, " . SqlQuote($duplicate) . ")");
        }
1381
        AppendComment($duplicate, $::COOKIE{'Bugzilla_login'}, "*** Bug $::FORM{'id'} has been marked as a duplicate of this bug. ***");
1382
        CheckFormFieldDefined(\%::FORM,'comment');
1383 1384
        SendSQL("INSERT INTO duplicates VALUES ($duplicate, $::FORM{'id'})");
        print "<TABLE BORDER=1><TD><H2>Duplicate notation added to bug $duplicate</H2>\n";
1385
        system("./processmail", $duplicate, $::COOKIE{'Bugzilla_login'});
1386 1387 1388
        print "<TD><A HREF=\"show_bug.cgi?id=$duplicate\">Go To BUG# $duplicate</A></TABLE>\n";
    }

1389
    foreach my $k (keys(%dependencychanged)) {
1390
        print "<TABLE BORDER=1><TD><H2>Checking for dependency changes on bug $k</H2>\n";
1391
        system("./processmail", $k, $::COOKIE{'Bugzilla_login'});
1392 1393 1394
        print "<TD><A HREF=\"show_bug.cgi?id=$k\">Go To BUG# $k</A></TABLE>\n";
    }

terry%netscape.com's avatar
terry%netscape.com committed
1395 1396
}

1397
if (defined $::next_bug) {
1398
    print("<P>The next bug in your list is:\n");
1399 1400
    $::FORM{'id'} = $::next_bug;
    print "<HR>\n";
terry%netscape.com's avatar
terry%netscape.com committed
1401

1402
    navigation_header();
1403
    do "bug_form.pl";
terry%netscape.com's avatar
terry%netscape.com committed
1404
} else {
1405
    navigation_header();
1406
    PutFooter();
terry%netscape.com's avatar
terry%netscape.com committed
1407
}