- 08 Nov, 2014 2 commits
-
-
Max Kellermann authored
On "list albumartist", songs that have no AlbumArtist tag will use the Artist tag. However, if AlbumArtist is disabled via "metadata_to_use", the TagBuilder::AddItem() call is ignored, and PrintUniqueTag() attempts to print a nullptr string. This commit fixes the problem by attempting the fallback only if AlbumArtist is not disabled.
-
Max Kellermann authored
-
- 07 Nov, 2014 5 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
When uri_apply_base() was moved from db/upnp/Util.cpp to util/UriUtil.cpp, the parameter order was changed, however without swapping the parameters in the ContentDirectoryService constructor.
-
Max Kellermann authored
Fixes crash in the "audiofile" decoder while logging the seek error.
-
Max Kellermann authored
-
- 04 Nov, 2014 1 commit
-
-
Max Kellermann authored
-
- 02 Nov, 2014 19 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
Fixes playback of redirected streams.
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
Use the new uri_get_suffix() overload that removes the query string.
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
Many years ago, FAAD had a serious ABI bug: the NeAACDecInit() prototype in its header declared the "samplerate" parameter to be "unsigned long *", but internally, the function assumed it was "uint32_t *" instead. On 32 bit machines, that was no difference, but on 64 bit, this left one portion of the return value uninitialized; and worse, on big-endian, the wrong word was filled. This bug had to be worked around in MPD (commit 9c4e97a6). A few months later, the bug was fixed in the FAAD CVS in commit 1.117 on file libfaad/decoder.c; the commit message was: "Use public headers internally to prevent duplicate declarations" The commit message was too brief at best; the problem was not duplicate declarations, but a prototype mismatch. No mention of the bug fix in the ChangeLog. The MPD project never learned about this bug fix, and so MPD would always pass a "uin32_t *" dressed up as a "unsigned long *". Nearly 6 years later, it's about time to fix this second ABI problem. Let's kill the workaround!
-
Steven OBrien authored
-
Max Kellermann authored
-
Max Kellermann authored
A mutex acts as a memory barrier, and thus "volatile" is not necessary.
-
Max Kellermann authored
Fixes buffer overflow bug.
-
Max Kellermann authored
-
Max Kellermann authored
-
- 01 Nov, 2014 3 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
Use the new uri_get_suffix() overload that removes the query string.
-
Max Kellermann authored
-
- 31 Oct, 2014 3 commits
-
-
NanoTech authored
-
Max Kellermann authored
-
- 28 Oct, 2014 2 commits
-
-
Max Kellermann authored
Negating an unsigned integer does not work.
-
Max Kellermann authored
-
- 26 Oct, 2014 1 commit
-
-
Max Kellermann authored
-
- 25 Oct, 2014 2 commits
-
-
Max Kellermann authored
Works around the "PCM conversion from f to dsd is not implemented" error message that prevents DSD playback.
-
Max Kellermann authored
Many years ago, FAAD had a serious ABI bug: the NeAACDecInit() prototype in its header declared the "samplerate" parameter to be "unsigned long *", but internally, the function assumed it was "uint32_t *" instead. On 32 bit machines, that was no difference, but on 64 bit, this left one portion of the return value uninitialized; and worse, on big-endian, the wrong word was filled. This bug had to be worked around in MPD (commit 9c4e97a6). A few months later, the bug was fixed in the FAAD CVS in commit 1.117 on file libfaad/decoder.c; the commit message was: "Use public headers internally to prevent duplicate declarations" The commit message was too brief at best; the problem was not duplicate declarations, but a prototype mismatch. No mention of the bug fix in the ChangeLog. The MPD project never learned about this bug fix, and so MPD would always pass a "uin32_t *" dressed up as a "unsigned long *". Nearly 6 years later, it's about time to fix this second ABI problem. Let's kill the workaround!
-
- 24 Oct, 2014 2 commits
-
-
Max Kellermann authored
-
Steven OBrien authored
-