1. 12 Nov, 2009 1 commit
    • Max Kellermann's avatar
      include config.h in all sources · 5b82ffc2
      Max Kellermann authored
      After we've been hit by Large File Support problems several times in
      the past week (which only occur on 32 bit platforms, which I don't
      have), this is yet another attempt to fix the issue.
      5b82ffc2
  2. 04 Nov, 2009 2 commits
  3. 01 Nov, 2009 5 commits
  4. 13 Oct, 2009 1 commit
  5. 05 Jul, 2009 2 commits
  6. 28 Apr, 2009 1 commit
    • Max Kellermann's avatar
      song_save: don't call tag_free(NULL) · 7d9316a5
      Max Kellermann authored
      When a song was in the database twice (which shouldn't happen), and
      the first song had no tag items, MPD calledd tag_free(NULL).  Add a
      check to that source location, and an assertion to tag_free().
      7d9316a5
  7. 15 Mar, 2009 1 commit
  8. 13 Mar, 2009 1 commit
    • Avuton Olrich's avatar
      all: Update copyright header. · 0aee49bd
      Avuton Olrich authored
      This updates the copyright header to all be the same, which is
      pretty much an update of where to mail request for a copy of the GPL
      and the years of the MPD project. This also puts all committers under
      'The Music Player Project' umbrella. These entries should go
      individually in the AUTHORS file, for consistancy.
      0aee49bd
  9. 27 Feb, 2009 1 commit
  10. 14 Jan, 2009 3 commits
  11. 13 Jan, 2009 1 commit
  12. 03 Jan, 2009 1 commit
  13. 28 Dec, 2008 1 commit
  14. 08 Oct, 2008 5 commits
  15. 07 Oct, 2008 1 commit
  16. 06 Oct, 2008 3 commits
    • Eric Wong's avatar
      song: stop storing song_type · f1c53fe0
      Eric Wong authored
      We already know if a song is a URL or not based on whether it
      has parentDir defined or not.  Hopefully one day in the future
      we can drop HTTP support from MPD entirely when an HTTP
      filesystem comes along and we can access streams via open(2).
      f1c53fe0
    • Eric Wong's avatar
      song: use flex arrays to store song->url · 267b2cd6
      Eric Wong authored
      Reduce the number of allocations we make, so there's less
      pressure on the allocator and less overhead to keep track
      of the allocations in.
      267b2cd6
    • Eric Wong's avatar
      song: get rid of newNullSong() · 43761441
      Eric Wong authored
      It didn't save us any lines of code nor did it do anything
      useful since we would overwrite everything anyways.
      43761441
  17. 23 Sep, 2008 3 commits
    • Eric Wong's avatar
      songvec: remove songvec_prune · 28d39948
      Eric Wong authored
      Any pruned files will be noticed during update and pruned
      from the live database, so this inefficient function can
      go away and never come back.
      28d39948
    • Eric Wong's avatar
      Don't try to prune unless we're updating · cfc2dd3e
      Eric Wong authored
      Pruning is very expensive and we won't need it in the future
      anyways.  This brings startup back to previous speeds (before
      songvec changes).
      cfc2dd3e
    • Eric Wong's avatar
      Replace SongList with struct songvec · 0bec1d38
      Eric Wong authored
      Our linked-list implementation is wasteful and the
      SongList isn't modified enough to benefit from being a linked
      list.  So use a more compact array of song pointers which
      saves ~200K on a library with ~9K songs (on x86-32).
      0bec1d38
  18. 07 Sep, 2008 3 commits
    • Max Kellermann's avatar
      tag: added buffered versions of the tag_print.c code · 59efed3e
      Max Kellermann authored
      Currently, when the tag cache is being serialized to hard disk, the
      stdio buffer is flushed before every song, because tag_print.c
      performs unbuffered writes on the raw file descriptor.  Unfortunately,
      the fdprintf() API allows buffered I/O only for a client connection by
      looking up the client pointer owning the file descriptor - for stdio,
      this is not possible.  To re-enable proper stdio buffering, we have to
      duplicate the tag_print.c code without fprintf() instead of our custom
      fdprintf() hack.  Add this duplicated code to tag_save.c.
      59efed3e
    • Max Kellermann's avatar
      song: moved code to song_print.c, song_save.c · 75aa8dad
      Max Kellermann authored
      Move everything which dumps song information (via tag_print.c) to a
      separate source file.  song_print.c gets code which writes song data
      to the client; song_save.c is responsible for serializing songs from
      the tag cache.
      75aa8dad
    • Max Kellermann's avatar
      tag: moved code to tag_print.c · 386c3031
      Max Kellermann authored
      Move everything which dumps a tag to a file descriptor to tag_print.c.
      This relaxes dependencies and splits the code into smaller parts.
      386c3031
  19. 06 Sep, 2008 1 commit
    • Eric Wong's avatar
      tag: fix segfault on update · 092bdf3d
      Eric Wong authored
      clearMpdTag could be called on a tag that was still in a
      tag_begin_add transaction before tag_end_add is called.  This
      was causing free() to attempt to operate on bulk.items; which is
      un-free()-able.  Now instead we unmark the bulk.busy to avoid
      committing the tags to the heap only to be immediately freed.
      
      Additionally, we need to remember to call tag_end_add() when
      a song is updated before we NULL song->tag to avoid tripping
      an assertion the next time tag_begin_add() is called.
      092bdf3d
  20. 29 Aug, 2008 3 commits
    • Max Kellermann's avatar
      tag: try not to reallocate tag.items in every add() call · 1aa34573
      Max Kellermann authored
      If many tag_items are added at once while the tag cache is being
      loaded, manage these items in a static fixed list, instead of
      reallocating the list with every newly created item.  This reduces
      heap fragmentation.
      
      Massif results again:
      
       mk before:  total 12,837,632; useful 10,626,383; extra 2,211,249
       mk now:     total 12,736,720; useful 10,626,383; extra 2,110,337
      
      The "useful" value is the same since this patch only changes the way
      we allocate the same amount of memory, but heap fragmentation was
      reduced by 5%.
      1aa34573
    • Max Kellermann's avatar
      song: don't export newNullSong() · 03152206
      Max Kellermann authored
      The function newNullSong() is only used internally in song.c.
      03152206
    • Max Kellermann's avatar
      tag: renamed functions, no CamelCase · 91502cd7
      Max Kellermann authored
      91502cd7