- 02 Nov, 2008 16 commits
-
-
Max Kellermann authored
These two functions will care about memory allocation and deallocation in the future.
-
Max Kellermann authored
Add doxygen compatible comments.
-
Max Kellermann authored
The "volatile" keyword doesn't help here, because we have proper memory barriers, but it disables some optimizations. Remove it.
-
Max Kellermann authored
The name "num_chunks" expresses the meaning of the variable better.
-
Max Kellermann authored
Rename all variables and struct members.
-
Max Kellermann authored
Don't bother to pass these values as parameters to tail_chunk().
-
Max Kellermann authored
-
Max Kellermann authored
Last music_pipe rename patch: renamed the global variable (singleton).
-
Max Kellermann authored
Replace all direct music_pipe struct accesses with wrapper functions. The compiled machine code is the same, but this way, we can change struct internals more easily.
-
Max Kellermann authored
Eliminate the deprecated utils.h memory allocation functions.
-
Max Kellermann authored
.. and rename dc.audioFormat to dc.in_audio_format. The music pipe does not need to know the audio format, and its former "audioFormat" property indicated the format of the most recently added chunk, which might be confusing when you are reading the oldest chunks.
-
Max Kellermann authored
Don't make tail_chunk() calculate the frame size again.
-
Max Kellermann authored
Rename all functions to the new prefix.
-
Max Kellermann authored
.. and rename ob_chunk to struct music_chunk.
-
Max Kellermann authored
No CamelCase in the file name. The output_buffer struct is going to be renamed to music_pipe. There are so many buffer levels in MPD, and calling this one "output buffer" is wrong, because it's not the last buffer before the music reaches the output devices.
-
Max Kellermann authored
Commit 1a4a3e1f moved decoders into a static array, but failed to enable those plugins who did not have an init() method at all. This patch corrects the "enabled" check.
-
- 01 Nov, 2008 9 commits
-
-
Max Kellermann authored
The strings were constant, but the pointers weren't. C syntax is somewhat tricky..
-
Max Kellermann authored
All decoder_plugin structs are initialized at compile time, and must never change.
-
Max Kellermann authored
Currently, there is no way to dynamically load decoder plugins, thus we don't need a dynamic list to manage them.
-
Max Kellermann authored
The decoder_plugin structs must never change. Don't work with non-const pointers.
-
Max Kellermann authored
Eliminating the deprecated linked list library.
-
Max Kellermann authored
Don't use the deprecated functions from utils.h.
-
Max Kellermann authored
Eliminate code already provided by GLib.
-
Max Kellermann authored
Return NULL instead of the input value if there is nothing to fix. This way, the caller doesn't have to use the xfree() hack.
-
Max Kellermann authored
Make the pointers "device" and "name" non-const, so we don't need the xfree() hack. The default value is expressed as NULL.
-
- 31 Oct, 2008 15 commits
-
-
Max Kellermann authored
We don't need to sanitize the path, because the mapper already checks for malformed paths.
-
Max Kellermann authored
Make map_directory_child_fs() refuse the names "." and "..". This is currently the interface where an attacker may inject a manipulated path (through the "update" command).
-
Max Kellermann authored
Nearly all mapper functions can fail and will then return NULL. Add checks to all callers.
-
Max Kellermann authored
Added the function map_spl_utf8_to_fs() which replaces utf8_to_fs_playlist_path().
-
Max Kellermann authored
g_error() is fatal by default. Use g_warning() for non-fatal initialization errors.
-
Max Kellermann authored
http://xkcd.com/292/
-
Max Kellermann authored
If nobody sent a command, the player isn't waiting for the decoder. Don't wake it up.
-
Max Kellermann authored
The player should always be woken up when the decoder quits.
-
Max Kellermann authored
Eliminate one goto in decodeStart() by moving some cleanup to decoder_task().
-
Max Kellermann authored
switch looks much nicer than if/elseif/... and gcc generates nice warnings when a new command is added to the enum.
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
Return bool instead of int.
-
Max Kellermann authored
Removed duplicated code.
-
Alam Arias authored
-