Even if there's a synchronisation mechanism between kernel32:debugger
and its children which ensures that child has finished writing to and
closed the blackbox logging file before reading it, there's no
guarantee that the file is not re-opened by another process: antivirus,
file indexing...
And according to [1], even the OS itself can still have opened references
to it.

So, always open/read the blackbox file in read share mode to work around
this issue.

Also, harden the code for potential errors, and be nicer in where
failures come from.

[1] https://learn.microsoft.com/en-us/windows-hardware/drivers/ifs/irp-mj-cleanup

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53456Signed-off-by: Eric Pouech <eric.pouech@gmail.com>

Investigating the test failures in MR!1823, it turns out
that sometimes in Win7, at process exit, not all the dll unload
debug events are sent (in traces, only the last loaded dll gets the
event).
I don't know what it only shows now :-(, but that seems very
replicable (it happens every time with new job to TestBot).

So mark the case of missing unload dll debug event as broken
(still checking that the load dll debug event has been received).
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>

It looks like the behavior changes when only this test is run vs when it
is run as part of the winetest suite.

This is probably because ChangeDisplaySettingsExW only sends the message
the first time it is called (since boot?).

Having other tests run before it, one of them probably changed display
settings already and we're not getting the message anymore.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53894

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>

The RtlU*ByteSwap() family:
- has FASTCALL calling convention
- is only exported from ntdll and ntoskrnl.exe in 32bit mode
  (didn't check ARM though)

Wine's support for RtlUlonglongByteSwap() doesn't follow these constraints.
Note: in __fastcall, 64bit paramaters are passed on the stack, to
RtlUlonglongByteSwap() calling convention acts as __stdcall.

So:
- fix ntdll.spec (resp. ntoskrnl.exe.spec) to only export
  (resp. forward) RtlUlonglongByteSwap for i386
- always provide an inline implementation in winternl.h
- reimplement ntdll.RtlUlonglongByteSwap() for i386 with
  __fastcall calling convention.
- fix ntdll/tests/rtl.c to use correct calling convention.
- add test in ntdll/tests/rtl.c for inlined version.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53536Signed-off-by: Eric Pouech <eric.pouech@gmail.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53222

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52394

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53918

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53912

Testing: kernel32:debugger, there's sometimes the following error:
debugger.c:1760: Test failed: unexpected instruction pointer 778B2A0C

Current test code has a workaround when this happens on last thread, but
this is clearly not sufficient.

Fix the test so that it grabs the thread context only in a place we're
sure it's in stopped state at breakpoint instruction.
(Current code likely catches cases where the thread is in bp signal
handling).

Rewrote the test to be in more logical order.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53143

Signed-off-by: Fabian Maurer <dark.shadow4@web.de>

The compiler may optimize out the assignment before free and then
second free on the bcrypt handle finds magic values in the freed memory.

This was omitted in b8732c80.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53485

This mimics the condition in the server.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53384

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>

Document fragments own reference to the inner window, so it must be unlinked.
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>

GCC12.2 warns about dereferencing a pointer to RpcPktHdr
while it has been allocated to the size of one of the packet
(hence smaller in some cases).

/home/eric/work/wine/dlls/rpcrt4/rpc_message.c:111:26: warning: array subscript 'RpcPktHdr[0]' is partly outside array bounds of 'unsigned char[24]' [-Warray-bounds]
  111 |   Header->common.rpc_ver = RPC_VER_MAJOR;

This patch fixes the warnings by accessing the created object
through a pointer to their type (and not through the union).
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>

wined3d: Always bind to GL_ELEMENT_ARRAY_BUFFER if the bind flags include WINED3D_BIND_INDEX_BUFFER.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53623

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54121