Commits · 55678ccaae1922310706dc741d78b00b9268ee8a · wine / wine-winehq

08 Oct, 2021 40 commits

krnl386: Fix a mistyped NULL check in WOWTHUNK_Init(). · 55678cca

authored Oct 08, 2021

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51802Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

55678cca

vbscript: Don't use function return value for call expressions. · 4f5e5cc6

authored Oct 08, 2021

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50758Signed-off-by: Robert Wilhelm <robert.wilhelm@gmx.net>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

4f5e5cc6

vbscript: Use a dedicated opcode for identifier expressions. · 2613f8bf
Jacek Caban authored Oct 08, 2021
```
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
2613f8bf
makefiles: Only build static libraries that are needed for linking. · 1699847d
Alexandre Julliard authored Oct 08, 2021
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
1699847d
dinput: Check for ReadFile errors and return DIERR_INPUTLOST. · 02207653
Rémi Bernon authored Oct 08, 2021
```
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
02207653

dinput: Call device read_callback while holding the internal CS. · c93813e1

authored Oct 08, 2021

And remove the device from the list of acquired devices if the callback
indicates a read error.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

c93813e1

dinput: Wait for CancelIoEx completion when unacquiring HID joysticks. · bbb68aea

authored Oct 08, 2021

Otherwise we may later write the cancelled status to invalid memory.

Also use a manual-reset event, as it should be for overlapped I/O, so
all waiters are woken up on cancel.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

bbb68aea

dinput: Hold the HID joystick CS when updating the device state. · 2b61d8dd

authored Oct 08, 2021

The read buffer is only used by the reading thread but the device state
is not, we should only update it while holding the CS.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

2b61d8dd

dinput: Do not wait for internal hooks inside the HID joystick CS. · 1014cfcf

authored Oct 08, 2021

This can cause some deadlocks as the internal thread will acquire the
device CS when reading the state.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

1014cfcf

xinput1_3: Register for device notifications to update controller list. · ebc70f78

authored Oct 08, 2021

Based on a patch from Andrew Eikum <aeikum@codeweavers.com>.

Dark Souls Remasters checks for xinput devices when it receives a
WM_DEVICECHANGE message. We would only poll for new devices if it had
been at least 2 seconds since the last check. So often, DS would receive
the message, but we would refuse to poll for devices, so the game would
think no controller was present.

This commit fixes that by also subscribing to event notifications and
triggering a poll.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

ebc70f78

xinput1_3: Initialize the controller list in the update thread. · 65ba91d4
Rémi Bernon authored Oct 08, 2021
```
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
65ba91d4

xinput1_3: Do not use delay loaded imports. · 986f88bf

authored Oct 08, 2021

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

986f88bf

xinput1_3: Destroy controllers when ReadFile fails and I/O is not pending. · 60db3898
Rémi Bernon authored Oct 08, 2021
```
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
60db3898

xinput1_3: Wait for CancelIoEx completion when disabling controllers. · 54db7610

authored Oct 08, 2021

Otherwise we may later write the cancelled status to invalid memory.

Also use a manual-reset event, as it should be for overlapped I/O, so
all waiters are waken up on cancel.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

54db7610

winebus.sys: Fix incorrect length when parsing uevent "HID_NAME=". · 5d022fd0

authored Oct 08, 2021

Signed-off-by: Ivo Ivanov <logos128@gmail.com>
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

5d022fd0

winebus.sys: Fix memory leaks in bus_event_queue functions. · 8f37de51

authored Oct 08, 2021

Signed-off-by: Ivo Ivanov <logos128@gmail.com>
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

8f37de51

ntdll: Return a failure if the unix call funcs don't exist. · 5689ec7b
Huw Davies authored Oct 08, 2021
```
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
5689ec7b

win32u: Use syscall interface for brush functions. · 33dddc84

authored Oct 08, 2021

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

33dddc84

gdi32: Use DLL forwarding for D3DKMT functions. · 2cc52c6e

authored Oct 08, 2021

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

2cc52c6e

gdi32: Don't export Wine extensions. · c166e969

authored Oct 08, 2021

Link directly to win32u instead.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

c166e969

user32: Link directly to win32u. · 80df54a4

authored Oct 08, 2021

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

80df54a4

gdi32: Rename gdidc.c to dc.c. · 5a66203b

authored Oct 08, 2021

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

5a66203b

ntoskrnl.exe: Fix use-after-free when freeing IRP. · de0e9ad9

authored Oct 07, 2021

Signed-off-by: Daniel Lehman <dlehman@esri.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

de0e9ad9

winebus.sys: Queue HID reports instead of overwritting the last one. · c9003fab

authored Oct 08, 2021

If the hidclass.sys read requests aren't done fast enough.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51824Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

c9003fab

winebus.sys: Keep a separate report buffer for each input report id. · 068511f8

authored Oct 08, 2021

And use them for IOCTL_HID_GET_INPUT_REPORT ioctls.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51824Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

068511f8

winebus.sys: Query and parse device report descriptor on device start. · 91329790

authored Oct 08, 2021

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51824Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

91329790

winebus.sys: Only keep a single read pending. · bd780ba6

authored Oct 08, 2021

The design of hidclass.sys prevents any concurrent irps, there's no
need to queue more.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51824Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

bd780ba6

dinput: Look for the PID set ramp force output report. · bbcee5c2

authored Oct 08, 2021

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

bbcee5c2

winebus.sys: Add a PID set ramp force output report. · 1c4523a9

authored Oct 08, 2021

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

1c4523a9

dinput: Look for the PID set constant force output report. · 25a86e46

authored Oct 08, 2021

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

25a86e46

winebus.sys: Add a PID set constant force output report. · 4a2db9f2

authored Oct 08, 2021

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

4a2db9f2

dinput: Implement support for the PID effect set condition report. · a971b48b
Rémi Bernon authored Oct 08, 2021
```
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
a971b48b

winebus.sys: Add a PID set condition output report. · c263fea1

authored Oct 08, 2021

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

c263fea1

dinput8/tests: Add some DIEFT_CONDITION HID joystick effect tests. · d224e8e8
Rémi Bernon authored Oct 08, 2021
```
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
d224e8e8
dinput: Implement support for the PID effect set envelope report. · c8b3e9b2
Rémi Bernon authored Oct 08, 2021
```
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
c8b3e9b2

winebus.sys: Add a PID set envelope output report. · 4b653ae0

authored Oct 08, 2021

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

4b653ae0

dinput: Implement support for the PID effect set periodic report. · 1b3e6b02
Rémi Bernon authored Oct 08, 2021
```
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
1b3e6b02

winebus.sys: Add a PID set periodic output report. · 6f2e6696

authored Oct 08, 2021

Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

6f2e6696

vcruntime140_1: Fix compilation with clang. · b0a61ee8

authored Oct 08, 2021

clang -c -o dlls/vcruntime140_1/except_x86_64.cross.o ../wine.src/dlls/vcruntime140_1/except_x86_64.c -Idlls/vcruntime140_1 \
  -I../wine.src/dlls/vcruntime140_1 -Iinclude -I../wine.src/include -I../wine.src/include/msvcrt \
  -D__WINESRC__ -D_UCRT -DWINE_CROSS_PE -Wall -target x86_64-windows -fno-strict-aliasing \
  -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Winit-self -Wno-pragma-pack \
  -Wstrict-prototypes -Wtype-limits -Wvla -Wwrite-strings -Wpointer-arith -Wabsolute-value \
  -Wno-format -Wnonnull -mcx16 -gdwarf-2 -gstrict-dwarf -g -O2
In file included from ../wine.src/dlls/vcruntime140_1/except_x86_64.c:25:
In file included from ../wine.src/include/wine/exception.h:25:
../wine.src/include/winternl.h:4239:82: error: unknown type name 'va_list'
NTSYSAPI NTSTATUS  WINAPI RtlFormatMessage(LPCWSTR,ULONG,BOOLEAN,BOOLEAN,BOOLEAN,__ms_va_list *,LPWSTR,ULONG,ULONG*);
Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

b0a61ee8

ws2_32: Close the new socket handle on CF_DEFER. · 3d521bc7

authored Oct 07, 2021

Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

3d521bc7