$ find . -name "*.sh" | xargs shellcheck -i SC2061

In ./roll-tarballs.sh line 159:
    find nx-X11/extras/Mesa/ -name Makefile.* | while read -r file; do rm "$file"; done
                                   ^--------^ SC2061: Quote the parameter to -name so the shell won't interpret it.

For more information:
  https://www.shellcheck.net/wiki/SC2061 -- Quote the parameter to -name so t...
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

See,

$ find . -name "*.sh" | xargs shellcheck -i SC2048

In ./nx-X11/lib/src/util/mkks.sh line 10:
}' $*
   ^-- SC2048: Use "$@" (with quotes) to prevent whitespace problems.

For more information:
  https://www.shellcheck.net/wiki/SC2048 -- Use "$@" (with quotes) to prevent...
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

See,

$ find . -name "*.sh" | xargs shellcheck -i SC2196

In ./roll-tarballs.sh line 163:
    sort "debian/patches/series" | grep -v '^#' | egrep "([0-9]+(_|-).*\.(full|full\+lite)\.patch)" | while read -r file
                                                  ^---^ SC2196: egrep is non-standard and deprecated. Use grep -E instead.

In ./roll-tarballs.sh line 200:
    sort "debian/patches/series" | grep -v '^#' | egrep "([0-9]+(_|-).*\.full\+lite\.patch)" | while read -r file
                                                  ^---^ SC2196: egrep is non-standard and deprecated. Use grep -E instead.

For more information:
  https://www.shellcheck.net/wiki/SC2196 -- egrep is non-standard and depreca...
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

See,

$ find . -name "*.sh" | xargs shellcheck -i SC2034

In ./roll-tarballs.sh line 34:
NULL=""
^--^ SC2034: NULL appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- NULL appears unused. Verify use (...
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

See,

$ find . -name "*.sh" | xargs shellcheck -i SC2002

For more information:
  https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

See,

$ find . -name "*.sh" | xargs shellcheck -i SC2045

In ./roll-tarballs.sh line 220:
for f in $(ls README* 2>/dev/null); do
         ^-----------------------^ SC2045: Iterating over ls output is fragile. Use globs.

For more information:
  https://www.shellcheck.net/wiki/SC2045 -- Iterating over ls output is fragi...
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

see,
$ find . -name "*.sh" | xargs shellcheck -i SC2086

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

See,

$ find . -name "*.sh" | xargs shellcheck -i SC2059

In ./version.sh line 34:
printf "${VER}"
       ^------^ SC2059: Don't use variables in the printf format string. Use printf '..%s..' "$foo".

For more information:
  https://www.shellcheck.net/wiki/SC2059 -- Don't use variables in the printf...
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

See,

$ find . -name "*.sh" | xargs shellcheck -i SC2148

In ./replace.sh line 1:
^-- SC2148: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.

For more information:
  https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y...
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

See,

find . -name "*.sh" | xargs shellcheck -i SC2162

[...]

For more information:
  https://www.shellcheck.net/wiki/SC2162 -- read without -r will mangle backs...
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

See,

$ find . -name "*.sh" | xargs shellcheck -i SC2006

In ./roll-tarballs.sh line 62:
    echo "HEAD (on branch `git rev-parse --abbrev-ref HEAD`)"
                          ^-- SC2006: Use $(...) notation instead of legacy backticked `...`.

Did you mean:
    echo "HEAD (on branch $(git rev-parse --abbrev-ref HEAD))"

In ./nx-X11/x-indent-all.sh line 2:
where=`dirname $0`
      ^----------^ SC2006: Use $(...) notation instead of legacy backticked `...`.

Did you mean:
where=$(dirname $0)

In ./nx-X11/x-indent.sh line 5:
INDENT=`which gnuindent || which gindent || which indent`
       ^-- SC2006: Use $(...) notation instead of legacy backticked `...`.

Did you mean:
INDENT=$(which gnuindent || which gindent || which indent)

For more information:
  https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le...
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

debian/patches: Drop 2002_xserver-xext_set-securitypolicy-path.debian.patch. Not required anymore since 689f811b.

 Regression fix.

Attributes GH PR #989: https://github.com/ArcticaProject/nx-libs/pull/989

We can now also drop all remaining NX specific lines from the security.c

see ArcticaProject/nx-libs#988

This reflects the path where the file is placed after installation.

It also obsoletes the NX_ALTERNATIVEPOLICYFILE.

Fixes ArcticaProject/nx-libs#988

Attributes GH PR #990: https://github.com/ArcticaProject/nx-libs/pull/990

Fixes ArcticaProject/nx-libs#987

Attributes GH PR #982: https://github.com/ArcticaProject/nx-libs/pull/982

Is required for compilations with musl.

See ArcticaProjects/nx-libs#975 and ArcticaProjects/nx-libs#976

Fixes ArcticaProject/nx-lib#975

Attributes GH PR #981: https://github.com/ArcticaProject/nx-libs/pull/981

This used to be printed only in TEST mode. Some while ago I had
changed that to WARNING (because it is a warning...). However, this
happens e.g. when running the xscreensaver vfeedback module and it
does not look like it is a problem at all. So let's suppress this
warning again and leave it to the TEST mode as it used to be.

although there is no functional difference...

Attributes GH PR #979: https://github.com/ArcticaProject/nx-libs/pull/979

PVS finding: "V522 There might be dereferencing of a potential null pointer 'props'"

PVS finding: "V522 There might be dereferencing of a potential null pointer 'nxagentConfiguredWindowList'."

PVS finding: "V522 There might be dereferencing of a potential null pointer"

PVs finding: "V547 Expression '!nxagentWMPassed' is always true."

"V547 Expression 'wmHints.input == 1' is always true."

PVS Studio: "V614 Potentially uninitialized variable 'glyphBox.*' used."