Attributes GH PR #990: https://github.com/ArcticaProject/nx-libs/pull/990

Fixes ArcticaProject/nx-libs#987

Attributes GH PR #982: https://github.com/ArcticaProject/nx-libs/pull/982

Is required for compilations with musl.

See ArcticaProjects/nx-libs#975 and ArcticaProjects/nx-libs#976

Fixes ArcticaProject/nx-lib#975

Attributes GH PR #981: https://github.com/ArcticaProject/nx-libs/pull/981

This used to be printed only in TEST mode. Some while ago I had
changed that to WARNING (because it is a warning...). However, this
happens e.g. when running the xscreensaver vfeedback module and it
does not look like it is a problem at all. So let's suppress this
warning again and leave it to the TEST mode as it used to be.

although there is no functional difference...

Attributes GH PR #979: https://github.com/ArcticaProject/nx-libs/pull/979

PVS finding: "V522 There might be dereferencing of a potential null pointer 'props'"

PVS finding: "V522 There might be dereferencing of a potential null pointer 'nxagentConfiguredWindowList'."

PVS finding: "V522 There might be dereferencing of a potential null pointer"

PVs finding: "V547 Expression '!nxagentWMPassed' is always true."

"V547 Expression 'wmHints.input == 1' is always true."

PVS Studio: "V614 Potentially uninitialized variable 'glyphBox.*' used."

"V701 realloc() possible leak: when realloc() fails in allocating
memory, original pointer 'nxagentReconnectErrorMessage' is
lost. Consider assigning realloc() to a temporary pointer."

"V575 The potential null pointer is passed into 'memcpy'
function. Inspect the first argument."

found by PVS Studio: "V522 There might be dereferencing of a potential
null pointer 'keymap'."

"V560 A part of conditional expression is always true: oldStatus ==
NotSynchronized."

"V701 realloc() possible leak: when realloc() fails in allocating
memory, original pointer 'nxagentDefaultColormaps' is lost. Consider
assigning realloc() to a temporary pointer."

"V575 The potential null pointer is passed into 'strlen'
function. Inspect the first argument. Check lines: 420, 403."

Code can only be reached if pPicture is non-NULL. Besides, pPicture
will be accessed later anyway, regardless of this check.

Finding of PVS Studio: "V547 Expression 'pPicture != NULL' is always true."

Based on PVS Studio finding: "V547 Expression 'data' is always true."

success would always be true at the beginning of the loop as it is part
of the loop condition.

Finding from PVS Studio: "V560 A part of conditional expression is
always true: success."

PVS Studio: "V592 The expression was enclosed by parentheses twice:
'((* pRed * (limg + 1)))'. One pair of parentheses is unnecessary or
misprint is present."

"V701 realloc() possible leak: when realloc() fails in allocating
memory, original pointer 'privAtomMap' is lost. Consider assigning
realloc() to a temporary pointer."

FIX PVS Studio finding "V575 The potential null pointer is passed into
'strlen' function. Inspect the first argument"

This used to be printed only in TEST mode. Some while ago I had
changed that to WARNING (because it is a warning...). However, this
happens e.g. when running the xscreensaver vfeedback module and it
does not look like it is a problem at all. So let's suppress this
warning again and leave it to the TEST mode as it used to be.