- 29 Dec, 2008 3 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
Only include headers which are really needed. os_compat.h aimed to make MPD easily portable, but was never actually made portable.
-
Viliam Mateicka authored
-
- 28 Dec, 2008 1 commit
-
-
Thomas Jansen authored
-
- 27 Dec, 2008 1 commit
-
-
Max Kellermann authored
When there are no archive plugins, we do not need the archive API at all. Drop all its overhead.
-
- 16 Dec, 2008 1 commit
-
-
Viliam Mateicka authored
-
- 08 Dec, 2008 1 commit
-
-
Avuton Olrich authored
MPD 0.13 and older followed all symbolic links. Although this can be a security problem (as it has always been), 0.14 should offer the same default behaviour as 0.13.
-
- 28 Nov, 2008 1 commit
-
-
Raphaël Rigo authored
The configuration options "follow_outside_symlinks" and "follow_inside_symlinks" let the user control whether MPD should follow symbolic links in the music directory. [mk: converted variables to "bool"; moved configuration to update_global_init()]
-
- 27 Nov, 2008 1 commit
-
-
Max Kellermann authored
Those two functions are called when MPD starts and exits. It allows the update library to perform global initialization and deinitialization. The implementations are currently empty.
-
- 24 Nov, 2008 1 commit
-
-
Thomas Jansen authored
-
- 22 Nov, 2008 1 commit
-
-
Max Kellermann authored
Renamed the local variable "basename", which shadows the POSIX function basename().
-
- 20 Nov, 2008 1 commit
-
-
Konstantin Sobolev authored
skip_symlinks() expects an UTF-8 encoded file name, but updateDirectory() passed ent->d_name (in file system encoding) to it. Convert it to UTF-8 first.
-
- 31 Oct, 2008 1 commit
-
-
Max Kellermann authored
Nearly all mapper functions can fail and will then return NULL. Add checks to all callers.
-
- 20 Oct, 2008 1 commit
-
-
Max Kellermann authored
GLib's g_path_get_basename() is much more reliable than mpd_basename(). The latter could be tricked into an assertion failure.
-
- 15 Oct, 2008 1 commit
-
-
Max Kellermann authored
Skip only the special directory entries "." and "..", don't skip all other "hidden" files.
-
- 14 Oct, 2008 3 commits
-
-
Max Kellermann authored
"idle" waits until something noteworthy happens on the server, e.g. song change, playlist modified, database updated. This allows clients to keep up to date without polling.
-
Max Kellermann authored
Don't follow relative symlinks which point into the music directory. This allows you to organize music with symbolic links, without MPD managing separate copies of each song.
-
Max Kellermann authored
The mapper library maps directory and song objects to file system paths. With this central library, the code mixture in path.c should be cleaned up, and we will be able to add neat features like aliasing.
-
- 13 Oct, 2008 5 commits
-
-
Max Kellermann authored
By always creating the parent directory, we can use delete_name_in() without further lookups. The parents which may non exist will be pruned later. An update request for a non-existing or empty directory should be quite unusual, so this doesn't add any measurable overhead.
-
Max Kellermann authored
In order to optimize buffer usage, pass only the base file name to updateInDirectory(). This way, updateInDirectory() may choose when to allocate a larger buffer for the full path.
-
Max Kellermann authored
-
Max Kellermann authored
delete_name_in() is similar to delete_path(), but it does not need to look up the parent directory.
-
Eric Wong authored
Previously only updates with subdirectories being specified could be queued. No harm in queueing full updates.
-
- 09 Oct, 2008 17 commits
-
-
Max Kellermann authored
There is only once update thread at a time. Make the "modified" flag global and remove the return values of most functions. Propagating an error is only useful for updateDirectory(), since updateInDirectory() will delete failed subdirectories.
-
Max Kellermann authored
-
Max Kellermann authored
When a song file was not modified, MPD printed the debug message "not a directory or music", because the first "if" branch did not return.
-
Max Kellermann authored
When the update queue is full, directory_update_init() did not free the path argument.
-
Max Kellermann authored
Since the return value cannot be -1 anymore, we can make it unsigned.
-
Max Kellermann authored
The documentation for directory_update_init() was incorrect: a job ID must be positive, not non-negative. If the update queue is full and no job was created, it makes more sense to return 0 instead of -1, because it is more consistent with the return value of isUpdatingDB().
-
Max Kellermann authored
When the update task is idle, there is no need to check for deleted songs. Return early from reap_update_task().
-
Max Kellermann authored
pthread_join() expects a "pointer to a pointer" parameter, but it got a "pointer to an enum". On AMD64, an enum is smaller than a pointer, leading to a buffer overflow.
-
Max Kellermann authored
Removed the local variable "was_empty": don't remember if the directory is new. Always call removeDeletedFromDirectory().
-
Max Kellermann authored
In updateInDirectory(), add new directories immediately and delete them when they turn out to be empty. This simplifies the code and allows us to eliminate addSubDirectoryToDirectory().
-
Max Kellermann authored
-
Max Kellermann authored
The recursive checks were performed in several functions, and sometimes a directory was checked twice.
-
Max Kellermann authored
When reading a new directory, copy the stat data (which we have anyway) to the directory struct. This may save a stat() in the future.
-
Max Kellermann authored
Pass a pointer to the stat struct to more functions.
-
Max Kellermann authored
updatePath() duplicated a lot of code from the more generic updateInDirectory(). Eliminate most of updatePath() and call updateInDirectory().
-
Max Kellermann authored
If the user requests database update during startup, call directory_update_init(). This should be changed to fully asynchronous update later. For this to work, main_notify has to be initialized before db_init().
-
Max Kellermann authored
The stat struct isn't going to be modified, make it const.
-