1. 14 Nov, 2018 5 commits
  2. 12 Nov, 2018 16 commits
  3. 11 Nov, 2018 5 commits
  4. 08 Nov, 2018 1 commit
    • Max Kellermann's avatar
      output/httpd: fix nullptr dereference crash bug · 583208db
      Max Kellermann authored
      When `metadata_sent` is `false`, the plugin assumes there is metadata
      which must be sent, even if no metadata page was passed to the plugin.
      Initializing it to `true` avoids dereferencing this `nullptr`.
      
      Fixes #412
      583208db
  5. 07 Nov, 2018 6 commits
  6. 06 Nov, 2018 4 commits
  7. 05 Nov, 2018 1 commit
  8. 04 Nov, 2018 2 commits
    • Max Kellermann's avatar
      793fd8c4
    • Max Kellermann's avatar
      decoder/ffmepg: fill AudioFormat from AVCodecContext, not AVCodecParameters · 6c602811
      Max Kellermann authored
      `AVCodecParameters` contains values from the codec detected by
      avformat_find_stream_info(), but after avcodec_open2(), a different
      codec might be selected with a different `AVSampleFormat`.  This leads
      to misinterpretation of data returned from FFmpeg, leading to random
      noise or silence.
      
      This was observed with FFmpeg 4.0.2 and a TS container file containing
      MP2.  A mp3-float codec was detected returning `AV_SAMPLE_FMT_FLTP`,
      but finally the `mpegaudiodec_fixed.c` was used, returning
      `AV_SAMPLE_FMT_S16`.
      
      By using the audio format from `AVCodecContext`, we ensure that MPD
      and FFmpeg always agree on the actual audio format in the buffer.
      
      This removes the FFmpeg bug workaround from commit e1b032cb which I
      assume is obsolete after 7 years.
      
      Fixes #380
      6c602811